Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean qos zenoh tests #1369

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
+197 −176
Open

Clean qos zenoh tests #1369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions rclpy/test/test_qos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import warnings

from rclpy.duration import Duration
from rclpy.impl.implementation_singleton import rclpy_implementation as _rclpy
from rclpy.qos import InvalidQoSProfileException
from rclpy.qos import qos_check_compatible
from rclpy.qos import qos_profile_system_default
Expand Down Expand Up @@ -187,8 +188,12 @@ def test_incompatible(self):
pub_qos, sub_qos
)

assert compatibility == QoSCompatibility.ERROR
assert reason != ''
if _rclpy.rclpy_get_rmw_implementation_identifier() != "rmw_zenoh_cpp":
assert compatibility == QoSCompatibility.ERROR
assert reason != ''
else:
assert compatibility == QoSCompatibility.OK
assert reason == ''

def test_warn_of_possible_incompatibility(self):
"""
Expand All @@ -206,5 +211,9 @@ def test_warn_of_possible_incompatibility(self):
pub_qos, sub_qos
)

assert compatibility == QoSCompatibility.WARNING
assert reason != ''
if _rclpy.rclpy_get_rmw_implementation_identifier() != "rmw_zenoh_cpp":
assert compatibility == QoSCompatibility.WARNING
assert reason != ''
else:
assert compatibility == QoSCompatibility.OK
assert reason == ''
Loading