Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hri_face_detect: 2.0.10-2 in 'humble/distribution.yaml' [bloom] #42869

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

severin-lemaignan
Copy link
Contributor

@severin-lemaignan severin-lemaignan commented Sep 16, 2024

Import package in hri_face_detect 2.0.10-2:

hri_face_detect

hri_face_detect is a ROS4HRI-compliant face detector. It relies on python3-mediapipe-pip, which means debian can not be automatically generated.

See CHANGELOG for full history.

@github-actions github-actions bot added the humble Issue/PR is for the ROS 2 Humble distribution label Sep 16, 2024
@sloretz sloretz added the held for sync Issue/PR has been held because the distribution is in a sync hold label Sep 17, 2024
@sloretz
Copy link
Contributor

sloretz commented Sep 17, 2024

Holding for Humble sync

@audrow audrow removed the held for sync Issue/PR has been held because the distribution is in a sync hold label Sep 19, 2024
@nuclearsandwich
Copy link
Member

New package review:

Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which means debian can not be automatically generated.

With this in mind, the release stanza of this pull request is invalid. Including a release stanza will create doomed-to-fail build farm jobs attempting to create source and binary packages for Ubuntu without available metadata.

@nuclearsandwich nuclearsandwich added the changes requested Maintainers have asked for changes to the pull request label Sep 20, 2024
Comment on lines +3179 to +3183
release:
tags:
release: release/humble/{package}/{version}
url: https://github.com/ros4hri/hri_face_detect-release.git
version: 2.0.10-2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stanza should be removed since the build farm binary packaging jobs will not succeed without metadata.

Copy link

github-actions bot commented Oct 5, 2024

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale Issue/PR hasn't been active in a while and may be closed. label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request humble Issue/PR is for the ROS 2 Humble distribution stale Issue/PR hasn't been active in a while and may be closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants