Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privacy_msgs: 1.1.0-1 in 'humble/distribution.yaml' [bloom] #42868

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

severin-lemaignan
Copy link
Contributor

@severin-lemaignan severin-lemaignan commented Sep 16, 2024

Increasing version of package(s) in repository privacy_msgs to 1.1.0-1:

privacy_msgs

1.1.0 (2024-09-16)
------------------
* {privacy_centre -> privacy_msgs}
* [doc] cleanup README
* Contributors: Séverin Lemaignan

1.0.0 (2024-02-16)
------------------
* {SensitiveData->PersonalDataProcessor}
* initial commit of privacy_msgs
* Contributors: Séverin Lemaignan

@github-actions github-actions bot added the humble Issue/PR is for the ROS 2 Humble distribution label Sep 16, 2024
@sloretz sloretz added the held for sync Issue/PR has been held because the distribution is in a sync hold label Sep 17, 2024
@sloretz
Copy link
Contributor

sloretz commented Sep 17, 2024

Holding for Humble sync

@audrow audrow removed the held for sync Issue/PR has been held because the distribution is in a sync hold label Sep 19, 2024
release:
tags:
release: release/humble/{package}/{version}
url: https://github.com/ros4hri/privacy_msgs-release.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@severin-lemaignan can we move this release repository to ros2-gbp?

I can start the PR and mirroring process to add it to the ros4hri team: https://github.com/ros2-gbp/ros2-gbp-github-org/blob/latest/ros4hri.tf

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please! (sorry, I always forget how the ros2-gbp process work. It is certainly documented somewhere, but I just don't seem to have the required mental bandwidth to handle it properly 😔)

@nuclearsandwich nuclearsandwich added the changes requested Maintainers have asked for changes to the pull request label Sep 20, 2024
@nuclearsandwich
Copy link
Member

An additional note after taking a moment to do full review. I don't think this meets REP-144 criteria. privacy_msgs is insufficiently scoped. I think hri_privacy_msgs could be an alternative.

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a little bit too generic for a REP 144 package naming standards. https://www.ros.org/reps/rep-0144.html

This looks to have one message which is very application specific. Which doesn't justify claiming the name privacy for the whole ROS ecosystem.

Please use a name that explains the scope of where this package is expected to be reused in a prefix otherwise making the name more specific. Possibly the privacy standard that it's targeted for, or the project that it's going to be used for.

@severin-lemaignan
Copy link
Contributor Author

thanks for the feedback. I'll revise accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request humble Issue/PR is for the ROS 2 Humble distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants