Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http_relay: 1.0.1-1 in 'melodic/distribution.yaml' [bloom] #37716

Closed
wants to merge 1 commit into from
Closed

http_relay: 1.0.1-1 in 'melodic/distribution.yaml' [bloom] #37716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions melodic/distribution.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4595,6 +4595,21 @@ repositories:
url: https://github.com/fkanehiro/hrpsys-base.git
version: master
status: maintained
http_relay:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another name that I think is pretty generic, and I'm actually not sure at all why it needs to be a ROS package. That is, it really just reverse proxies HTTP requests, and the only thing it seems to use ROS for is to get parameters from the global parameter server. It seems to me that this functionality could just be satisfied by pip installing a Python package.

That said, I could be missing something about how it operates, so feel free to correct me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this functionality isn't directly ROS-related. But it is robot-related. A few times we had devices which could not access outer networks directly.

I searched the whole apt and pip, but i haven't found any simple package for http proxying (except for big beefy frameworks).

And as it wasn't the first time we needed to run a http relay on the robots, I felt this would be a good package candidate.

Our latest use-case is directly embedding the proxy into sensor ROS driver.

I think this package follows the naming REP. The name clearly says what it does. Name collisions don't matter because any other package trying to achieve similar functionality would basically do the same. And org prefix doesn't make sense because there is nothing org-specific there.

doc:
type: git
url: https://github.com/ctu-vras/http_relay.git
version: master
release:
tags:
release: release/melodic/{package}/{version}
url: https://gitlab.fel.cvut.cz/cras/ros-release/http_relay.git
version: 1.0.1-1
source:
type: git
url: https://github.com/ctu-vras/http_relay.git
version: master
status: maintained
human_description:
doc:
type: git
Expand Down