Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROS Support page. #23

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nuclearsandwich
Copy link

This is based on the page that used to be at https://www.ros.org/support

I'm sure that there's more we can do but given how often this page is
cited it would be nice to have something up there.

This is based on the page that used to be at https://www.ros.org/support

I'm sure that there's more we can do but given how often this page is
cited it would be nice to have something up there.
@tfoote
Copy link
Member

tfoote commented Nov 5, 2021

That content is here: https://www.ros.org/blog/getting-started/# If anything we should redirect it to there instead possibly?

@kscottz
Copy link
Contributor

kscottz commented Nov 5, 2021

This is great and I really appreciate the help. I can handle styling the page, updating it, and adding a link to it in the footer/header. I'll merge it in next week along with a few other PRs. If you have anything else you want me to add, happy to take care of it.

@tfoote
Copy link
Member

tfoote commented Nov 5, 2021

@kscottz The content is already there under the getting started header. And it's been updated for ROS 2 What I didn't realize was that the sub-heading was available via the url to the anchor Getting Started is the concatenation of two pages. Install and Support https://web.archive.org/web/20211019043340/https://www.ros.org/support/

We can split it back that way.

@nuclearsandwich
Copy link
Author

I just updated the Support page to use the existing content from Getting Started.
What should be done with the Getting Started page?

As a side note, it's curious to me that the Getting Started page is considered a "blog post". Is that an intentional choice or should I contribute a change which makes a top-level getting-started page?

@tfoote
Copy link
Member

tfoote commented Nov 5, 2021

Yeah, everything us currently listed as under "/blog" I ticketed it at #25 All the standard pages shouldn't go under blog.

@tfoote
Copy link
Member

tfoote commented Nov 5, 2021

Can the "Getting Started" page use some sort of include to get both. Alternatively we could really use a redirect to maintain the old url but keep the structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants