Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the pesky "website may be down" errors during rosdep {init, update} #808

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

kunaltyagi
Copy link

@kunaltyagi kunaltyagi commented Apr 28, 2021

New desciption

While trying to recreate the env for bad networks, I found an pesky issue in rosdep init. This PR resolves that but not the handshake time-out issue.

Old description

On some networks, the following error is observed:

Hit https://raw.githubusercontent.com/ros/rosdistro/master/rosdep/python.yaml
ERROR: unable to process source [https://raw.githubusercontent.com/ros/rosdistro/master/rosdep/ruby.yaml]:
        <urlopen error ('_ssl.c:711: The handshake operation timed out',)> (https://raw.githubusercontent.com/ros/rosdistro/master/rosdep/ruby.yaml)

This PR resolves the issue by trying the connection multiple times. Increasing timeout was tried but did not always succeed.

Followup from #687

@nuclearsandwich Would it be possible to have a test env for this?

src/rosdep2/sources_list.py Outdated Show resolved Hide resolved
src/rosdep2/sources_list.py Outdated Show resolved Hide resolved
@kunaltyagi
Copy link
Author

kunaltyagi commented Apr 28, 2021

Failing tests (test_rosdep_sources_list):

  • test_SourcesListLoader_create_default
  • test_load_cached_sources_list

The failure messages look alright to me (bad host name not found). Will try reverting the whitespace change

EDIT: rewrote the change instead of relying on git merge. All tests passing now

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2021

Codecov Report

Merging #808 (3b330b3) into master (30a25a7) will decrease coverage by 0.89%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #808      +/-   ##
==========================================
- Coverage   74.96%   74.06%   -0.90%     
==========================================
  Files          42       42              
  Lines        3283     3285       +2     
==========================================
- Hits         2461     2433      -28     
- Misses        822      852      +30     
Impacted Files Coverage Δ
src/rosdep2/main.py 47.67% <0.00%> (-1.17%) ⬇️
src/rosdep2/sources_list.py 85.15% <56.00%> (-1.44%) ⬇️
src/rosdep2/gbpdistro_support.py 93.69% <100.00%> (-1.72%) ⬇️
src/rosdep2/rep3.py 93.33% <100.00%> (-6.67%) ⬇️
src/rosdep2/shell_utils.py 93.18% <0.00%> (-6.82%) ⬇️
src/rosdep2/meta.py 96.07% <0.00%> (-3.93%) ⬇️
src/rosdep2/platforms/osx.py 48.61% <0.00%> (-3.32%) ⬇️
src/rosdep2/platforms/source.py 88.26% <0.00%> (-2.29%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30a25a7...3b330b3. Read the comment docs.

@kunaltyagi kunaltyagi changed the title Support slow/bad networks as well Resolve the pesky "website may be down" errors during rosdep {init, update} May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants