Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script(Factories): Accept private keys via terminal input for signature signing. #80

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Script(Factories): Accept private keys via terminal input for signature signing. #80

merged 2 commits into from
Aug 28, 2024

Conversation

tringuyenskymavis
Copy link
Collaborator

Description

This PR refactors factory scripts to accept private keys via terminal input for signature signing.

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

TuDo1403
TuDo1403 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@TuDo1403 TuDo1403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tringuyenskymavis tringuyenskymavis merged commit 5b14d5c into release/v3.2.4 Aug 28, 2024
1 of 3 checks passed
@tringuyenskymavis tringuyenskymavis deleted the script/rework-factory-script branch August 28, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TuDo1403 TuDo1403 TuDo1403 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tringuyenskymavis @TuDo1403