feat(*): reduce gas by clone operators to MainchainGateway #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nxqbao
force-pushed
the
feat/reduce-gas-rework
branch
from
d7bc51e
to
bff5c9e
Compare
nxqbao
changed the title
nxqbao
changed the title
khanhtaskymaviscom
suggested changes
Mar 14, 2024
| /////////////////////////////////////////////// | ||
| // CALLBACKS | ||
| /////////////////////////////////////////////// | ||
|
|
There was a problem hiding this comment.
Do we need to implement supportsInterface?
There was a problem hiding this comment.
Added the supportsInterface, but cannot use this interface to generalize in the callee, where calls to multiple registers simultaneously.
src/extensions/bridge-operator-governance/BridgeManagerQuorum.sol
Outdated
Show resolved
Hide resolved
This reverts commit 7eb813a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist