Script: map anima token and refactor factory scripts #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nxqbao
reviewed
Jul 3, 2024
script/factories/mainchain/factory-maptoken-mainchain-sepolia.s.sol
Outdated
Show resolved
Hide resolved
script/factories/mainchain/factory-maptoken-mainchain-sepolia.s.sol
Outdated
Show resolved
Hide resolved
script/factories/mainchain/factory-maptoken-mainchain-ethereum.s.sol
Outdated
Show resolved
Hide resolved
tringuyenskymavis
force-pushed
the
script/map-anima-token-testnet
branch
from
811fd23
to
bd61967
Compare
nxqbao
approved these changes
Jul 24, 2024
| function run() public virtual; | ||
| function _initCaller() internal virtual returns (address); | ||
| function _initTokenList() internal virtual returns (uint256 totalToken, MapTokenInfo[] memory infos); | ||
|
|
||
| function _proposeAndExecute(Proposal.ProposalDetail memory proposal) internal { | ||
| proposal.executor = _governors[0]; | ||
| function _propose(Proposal.ProposalDetail memory proposal) internal virtual { |
There was a problem hiding this comment.
Suggested change
| function _propose(Proposal.ProposalDetail memory proposal) internal virtual { | |
| function _propose(Proposal.ProposalDetail memory proposal) internal { |
| ); | ||
| } | ||
|
|
||
| function _proposeAndExecuteProposal(Proposal.ProposalDetail memory proposal) internal { |
| _governorPKs.push(governorsPksM[i]); | ||
| for (uint256 i; i < mGovernors.length; ++i) { | ||
| _governors.push(mGovernors[i]); | ||
| _governorPKs.push(mGovernorsPk[i]); |
There was a problem hiding this comment.
create another PR to avoid load private keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds map anima token scripts and refactors factory scripts
Checklist