Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support batch directly gateway #41

Merged
merged 5 commits into from
Jun 20, 2024
Merged

feat: support batch directly gateway #41

merged 5 commits into from
Jun 20, 2024

Conversation

nxqbao
Copy link
Contributor

@nxqbao nxqbao commented Jun 20, 2024

Description

Deprecate Gateway Batcher, support the batch function natively in the gateway contract

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

TuDo1403
TuDo1403 reviewed Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@TuDo1403 TuDo1403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs to provide tests to verify

@nxqbao nxqbao merged commit 28215de into release/v3.2.2 Jun 20, 2024
1 check failed
@nxqbao nxqbao deleted the feat/support-batch-in-gateway branch June 20, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TuDo1403 TuDo1403 TuDo1403 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nxqbao @TuDo1403