Re: Fix search icon overlaping with the long search input placeholder text #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix for the overlap with the long search input placeholder text
Added a background color and changed color of the search icon SVG as a fix for the overlap with the long search input placeholder text
add search-icon as variable for dark and light themes
add search-icon as variable for dark and light themes
fixed semicolon
ronilaukkarinen
added a commit
that referenced
this pull request
Jul 3, 2023
|
Brilliant, thanks! @itbeard |
ronilaukkarinen
added a commit
that referenced
this pull request
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The redesigned version of #38
#717c9bto#535C76for the dark theme (this is equivalent of#717c9b+ 0.6 opacity + dark bg-color)#717c9bto#9FA4BBfor the light theme (this is equivalent of#717c9b+ 0.6 opacity + light bg-color)--icon-search(for both themes).search__icon .fa.activeclass)Dark theme
Before
After
Light theme
Before
After
HQ theme
Without changes (search icon the same as in dark theme)