feat: integrate rolldown hmr-poc

rolldown · Nov 15, 2024 · cb489c4 · cb489c4
1 parent 65d9acc
commit cb489c4
Show file tree

Hide file tree

Showing 31 changed files with 1,148 additions and 80 deletions.
diff --git a/packages/vite/package.json b/packages/vite/package.json
@@ -88,7 +88,8 @@
   "dependencies": {
     "esbuild": "^0.24.0",
     "postcss": "^8.4.48",
-    "rolldown": "https://pkg.pr.new/rolldown@3d47bd0",
+    "react-refresh": "^0.14.2",
+    "rolldown": "0.13.2-snapshot-a292401-20241105072341",
     "rollup": "^4.23.0"
   },
   "optionalDependencies": {

diff --git a/packages/vite/src/node/build.ts b/packages/vite/src/node/build.ts
@@ -1344,6 +1344,7 @@ const relativeUrlMechanisms: Record<
     `(typeof document === 'undefined' && typeof location === 'undefined' ? ${getFileUrlFromRelativePath(
       relativePath,
     )} : ${getRelativeUrlFromDocument(relativePath, true)})`,
+  app: () => 'todo',
 }
 /* end of copy */
 

diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts
@@ -99,6 +99,10 @@ import { resolveSSROptions, ssrConfigDefaults } from './ssr'
 import { PartialEnvironment } from './baseEnvironment'
 import { createIdResolver } from './idResolver'
 import { type OxcOptions, convertEsbuildConfigToOxcConfig } from './plugins/oxc'
+import {
+  type RolldownDevOptions,
+  rolldownDevHandleConfig,
+} from './server/environments/rolldown'
 
 const debug = createDebugger('vite:config', { depth: 10 })
 const promisifiedRealpath = promisify(fs.realpath)
@@ -518,6 +522,8 @@ export interface ExperimentalOptions {
    * @default true
    */
   enableNativePlugin?: boolean
+
+  rolldownDev?: RolldownDevOptions
 }
 
 export interface LegacyOptions {
@@ -1160,6 +1166,7 @@ export async function resolveConfig(
   // run config hooks
   const userPlugins = [...prePlugins, ...normalPlugins, ...postPlugins]
   config = await runConfigHook(config, userPlugins, configEnv)
+  config = mergeConfig(config, rolldownDevHandleConfig(config, configEnv))
 
   // Ensure default client and ssr environments
   // If there are present, ensure order { client, ssr, ...custom }

diff --git a/packages/vite/src/node/plugins/asset.ts b/packages/vite/src/node/plugins/asset.ts
@@ -275,7 +275,10 @@ export async function fileToUrl(
   id: string,
 ): Promise<string> {
   const { environment } = pluginContext
-  if (environment.config.command === 'serve') {
+  if (
+    environment.config.command === 'serve' &&
+    !environment.config.experimental.rolldownDev
+  ) {
     return fileToDevUrl(environment, id)
   } else {
     return fileToBuiltUrl(pluginContext, id)

diff --git a/packages/vite/src/node/plugins/html.ts b/packages/vite/src/node/plugins/html.ts
@@ -775,7 +775,13 @@ export function buildHtmlPlugin(config: ResolvedConfig): RolldownPlugin {
         tag: 'script',
         attrs: {
           ...(isAsync ? { async: true } : {}),
-          type: 'module',
+          ...(config.experimental.rolldownDev
+            ? {
+                defer: true,
+              }
+            : {
+                type: 'module',
+              }),
           // crossorigin must be set not only for serving assets in a different origin
           // but also to make it possible to preload the script using `<link rel="preload">`.
           // `<script type="module">` used to fetch the script with credential mode `omit`,

diff --git a/packages/vite/src/node/plugins/index.ts b/packages/vite/src/node/plugins/index.ts
@@ -45,11 +45,13 @@ export async function resolvePlugins(
   normalPlugins: Plugin[],
   postPlugins: Plugin[],
 ): Promise<Plugin[]> {
+  const rolldownDev = config.experimental.rolldownDev
   const isBuild = config.command === 'build'
   const isWorker = config.isWorker
-  const buildPlugins = isBuild
-    ? await (await import('../build')).resolveBuildPlugins(config)
-    : { pre: [], post: [] }
+  const buildPlugins =
+    isBuild || rolldownDev
+      ? await (await import('../build')).resolveBuildPlugins(config)
+      : { pre: [], post: [] }
   const { modulePreload } = config.build
   const depOptimizationEnabled =
     !isBuild &&
@@ -60,7 +62,7 @@ export async function resolvePlugins(
 
   return [
     depOptimizationEnabled ? optimizedDepsPlugin() : null,
-    isBuild ? metadataPlugin() : null,
+    rolldownDev || isBuild ? metadataPlugin() : null,
     !isWorker ? watchPackageDataPlugin(config.packageCache) : null,
     !isBuild ? preAliasPlugin(config) : null,
     enableNativePlugin
@@ -118,9 +120,18 @@ export async function resolvePlugins(
     htmlInlineProxyPlugin(config),
     cssPlugin(config),
     config.oxc !== false
-      ? enableNativePlugin
-        ? nativeTransformPlugin()
-        : oxcPlugin(config)
+      ? rolldownDev
+        ? createBuiltinPluginWithEnvironmentSupport(
+            'native:transform',
+            (environment) =>
+              nativeTransformPlugin({
+                reactRefresh:
+                  environment.name === 'client' && rolldownDev?.reactRefresh,
+              }),
+          )
+        : enableNativePlugin
+          ? nativeTransformPlugin()
+          : oxcPlugin(config)
       : null,
     enableNativePlugin
       ? nativeJsonPlugin({
@@ -141,7 +152,7 @@ export async function resolvePlugins(
     enableNativePlugin ? nativeWasmFallbackPlugin() : wasmFallbackPlugin(),
     definePlugin(config),
     cssPostPlugin(config),
-    isBuild && buildHtmlPlugin(config),
+    (rolldownDev || isBuild) && buildHtmlPlugin(config),
     workerImportMetaUrlPlugin(config),
     assetImportMetaUrlPlugin(config),
     ...buildPlugins.pre,