Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get hugoversion from file #331

Merged
merged 4 commits into from
Apr 18, 2024
Merged

get hugoversion from file #331

merged 4 commits into from
Apr 18, 2024

Conversation

drmowinckels
Copy link
Member

No description provided.

@drmowinckels drmowinckels requested a review from a team as a code owner April 18, 2024 09:51
Copy link
Contributor

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@cosimameyer
Copy link
Contributor

Agree :) But it looks like a GH token is missing:

Error: Unhandled error: Error: Input required and not supplied: github-token

@drmowinckels
Copy link
Member Author

actually the token wasnt the real problem here, but that I didnt checkout the repo first, so the hugoversion file was not available :D

But the fact that the build failure notification fails because the token doesnt work is something I just dont get! It works just fine for the build preview notifications, so why not the failure? I'm really confused about that.

@drmowinckels
Copy link
Member Author

only reason this is failing now, is because of a rladies blog image that no longer exists.
waiting for a review and merge of this before testing build again: rladies/awesome-rladies-blogs#92

Copy link

Test build failed 😭 Check out the build logs.

@drmowinckels drmowinckels merged commit 19e79fe into main Apr 18, 2024
1 of 2 checks passed
@drmowinckels drmowinckels deleted the hugover branch April 18, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants