refactor(source): prefer options_with_secret over with_properties in SpecificParserConfig::new
#19900
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in `SpecificParserConfig::new`
xiangjinwu
commented
Dec 23, 2024
| let options_with_secret = | ||
| LocalSecretManager::global().fill_secrets(options.clone(), secret_refs.clone())?; | ||
| LocalSecretManager::global().fill_secrets(options, secret_refs)?; |
There was a problem hiding this comment.
unnecessary clone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The PR #17456 (commit 96de664) updated one occurrence below but missed the other two fixed in this PR.
risingwave/src/connector/src/parser/mod.rs
Line 1287 in 96de664
Checklist
Documentation
Release note