Address https://github.com/riscv/riscv-debug-spec/issues/985 #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix minor AsciiDoc conversion problem.
Fix asciidoc conversion for DXLEN definition.
|
Since the spec is frozen, I think we need to run this through architecture review. Can you rebase and submit this PR to be relative to rc2? Then we can include it in the batch of changes I was going to send over there today but haven't yet, so we can still squeeze this in. |
|
I just rebased to rc2. |
|
Well, that doesn't look right. Did you want me to rebase to rc2 and have the PR merge into rc2? I don't know how to change the target branch of the PR. |
|
I think that I figured that out but now there are additional changes that we already dealt with in different PRs. |
|
I don't quite understand what's going on with this history. I made #987 which was easier than trying to figure this out. |
|
OK. We can close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that this bug fix should be addressed before ratification.
/cc @en-sc