Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vector: disassemble: Let operand ordering be vd, [vrf]s1, vs2 to vector multiply-add instructions #1797

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

YenHaoChen
Copy link
Collaborator

Vector integer multiply-add instructions have a different assembly format to others. Specifically, the operand ordering of these instructions is rd, [vr]s1, vs2, while one of the others is rd, vs2, [vr]s1. (I was wondering whether this is a bug to the spec. Please correct me if I am wrong about this.)

image

Copy link
Collaborator

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…r single-width integer multiply-add instructions
…r widening integer multiply-add instructions
…r single-width floating-point fused multiply-add instructions
…r widening floating-point fused multiply-add instructions
@YenHaoChen YenHaoChen changed the title vector: disassemble: Let operand ordering be vd, [vr]s1, vs2 to vector integer multiply-add instructions vector: disassemble: Let operand ordering be vd, [vrf]s1, vs2 to vector multiply-add instructions Sep 3, 2024
@YenHaoChen
Copy link
Collaborator Author

@aswaterman Thank you for the review. I revised the PR and made the following changes.

  • Breakdown the commit by instruction group from the debug spec, i.e., splitting d398872 into ff62109 and 7f38a50.
  • Let operand ordering be vd, [vf]s1, vs2 to vector floating-point fused multiply-add instructions, i.e., adding b47d0ba and 6a1a5db.

Copy link
Collaborator

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks.

@aswaterman
Copy link
Collaborator

@YenHaoChen I sent you a github invite with write permissions so that you can directly participate in PR reviews (and so that you can merge your own PRs once they're approved).

@aswaterman aswaterman merged commit cb78f09 into riscv-software-src:master Sep 3, 2024
3 checks passed
@YenHaoChen YenHaoChen deleted the pr-vector branch September 3, 2024 05:14
@YenHaoChen
Copy link
Collaborator Author

@aswaterman Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants