Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Smdbltrp #1722

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Add Smdbltrp #1722

merged 1 commit into from
Aug 18, 2024

Conversation

ved-rivos
Copy link
Contributor

@ved-rivos ved-rivos commented Jul 4, 2024

@ved-rivos
Copy link
Contributor Author

This PR has a encoding.h change which is not merged upstream in riscv-opcodes yet. I will refresh it once the riscv-opcodes PR riscv/riscv-opcodes#257 gets merged.

@aswaterman
Copy link
Collaborator

I merged the riscv-opcodes PR using a merge commit. The SHA hash is still valid, so there is no need to refresh encoding.h.

Please squash the two commits into a single commit, though.

I’ll perform a code review next week.

Copy link
Collaborator

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think about this one too deeply, but it looks good to me based on a cursory review. Thanks!

@aswaterman
Copy link
Collaborator

@ved-rivos please fix the new conflicts and rebase/squash, then ping me to merge it.

@ved-rivos
Copy link
Contributor Author

@aswaterman thanks. The conflicts have been resolved.

@ved-rivos
Copy link
Contributor Author

@aswaterman - ptal if further changes are needed.

@aswaterman
Copy link
Collaborator

@ved-rivos thanks for the ping; I must've missed your previous message.

@aswaterman aswaterman merged commit f09b024 into riscv-software-src:master Aug 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants