-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable more configuration using the DTB #1721
Enable more configuration using the DTB #1721
Conversation
a37abc6
to
a09ac9d
Compare
I don't expect to have time to review this one in the next few days, but @jerryz123 has my proxy. |
No rush. Unfortunately, @jerryz123 wrote the main parts of this PR so I don't think it's fair to have him also review it :) |
True. Well, LMK when it's ready for review and I'll take a look when I have time. |
It's ready whenever you are. Thanks! |
ca174f6
to
f3e7fa8
Compare
@aswaterman any update on this? |
CI issues look unrelated to this PR (timing out on fetching openocd). |
@jerryz123 Can you re-run the CI test that is failing? |
I clicked the rerun button. I hope to review the PR tomorrow. |
I think there is a problem with RISC-V OpenOCD. Looks like the https://git.savannah.nongnu.org/git/git2cl.git/ repo doesn't work anymore. In any case, thanks! |
It’s probably a transient outage; let’s try again tomorrow. |
CI passed so ready when you are. Thanks! |
13a9c50
to
226419d
Compare
Hopefully tomorrow... |
This incidentally makes it easier to support heterogeneous-hart configs in the future
226419d
to
deeda9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for organizing this PR such that it was easy to review.
There's one bit of refactoring I want to do, but I'll take care of it as my penance for taking so long.
Thanks! |
Addresses parts of #1716
Thanks @jerryz123 for the main work on this.
--dump-dts
if the DTB is given.