Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more configuration using the DTB #1721

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Jul 3, 2024

Addresses parts of #1716

Thanks @jerryz123 for the main work on this.

  • A DTB that is passed in is used to set the number of harts, ISA, PMPs, MMU, and more of Spike.
    • Note: Device extensions that generate a DTS string do not affect the output of --dump-dts if the DTB is given.
    • Note: DTB provided memory regions are not used.
  • Correctly catches interactive traps v.s. other traps in interactive mode.

@jerryz123
Copy link
Collaborator

Can you squash 751ab8f into 433c16c? (But don't squash all the commits together).

riscv/dts.cc Outdated Show resolved Hide resolved
@abejgonzalez
Copy link
Contributor Author

Can you squash 751ab8f into 433c16c? (But don't squash all the commits together).

Done

@abejgonzalez abejgonzalez force-pushed the dts_parsing branch 2 times, most recently from a37abc6 to a09ac9d Compare July 3, 2024 22:28
@aswaterman
Copy link
Collaborator

I don't expect to have time to review this one in the next few days, but @jerryz123 has my proxy.

@abejgonzalez
Copy link
Contributor Author

I don't expect to have time to review this one in the next few days, but @jerryz123 has my proxy.

No rush. Unfortunately, @jerryz123 wrote the main parts of this PR so I don't think it's fair to have him also review it :)

@aswaterman
Copy link
Collaborator

True. Well, LMK when it's ready for review and I'll take a look when I have time.

@abejgonzalez
Copy link
Contributor Author

True. Well, LMK when it's ready for review and I'll take a look when I have time.

It's ready whenever you are. Thanks!

@abejgonzalez
Copy link
Contributor Author

@aswaterman any update on this?

@abejgonzalez
Copy link
Contributor Author

CI issues look unrelated to this PR (timing out on fetching openocd).

@abejgonzalez
Copy link
Contributor Author

@jerryz123 Can you re-run the CI test that is failing?

@aswaterman
Copy link
Collaborator

I clicked the rerun button.

I hope to review the PR tomorrow.

@abejgonzalez
Copy link
Contributor Author

I clicked the rerun button.

I hope to review the PR tomorrow.

I think there is a problem with RISC-V OpenOCD. Looks like the https://git.savannah.nongnu.org/git/git2cl.git/ repo doesn't work anymore.

In any case, thanks!

@aswaterman
Copy link
Collaborator

It’s probably a transient outage; let’s try again tomorrow.

@abejgonzalez
Copy link
Contributor Author

It’s probably a transient outage; let’s try again tomorrow.

CI passed so ready when you are. Thanks!

@abejgonzalez abejgonzalez force-pushed the dts_parsing branch 2 times, most recently from 13a9c50 to 226419d Compare July 31, 2024 23:50
@aswaterman
Copy link
Collaborator

Hopefully tomorrow...

Copy link
Collaborator

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for organizing this PR such that it was easy to review.

There's one bit of refactoring I want to do, but I'll take care of it as my penance for taking so long.

@aswaterman aswaterman merged commit fdd2570 into riscv-software-src:master Aug 1, 2024
3 checks passed
@abejgonzalez
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants