Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mcontrol/mcontrol6 on fetch #1459

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Sep 14, 2023

  1. triggers: fix data mcontrol/mcontrol6 on fetching instruction data

    The fetching instruction data are in refill_icache() instead of
    fetch_slow_path(). This commit moves the mcontrol/mcontrol6 checking
    from fetch_slow_path() to refill_icache() for the correct data value.
    
    For example, consider an instruction 0xe9830313 (addi t1, t1, -360). The
    previous implementation fires mcontrol data triggers with tdata2=0xe983
    and tdata2=0x0313 but does not fire one with tdata2=0xe9830313, which is
    incorrect. This commit fixes the issue.
    YenHaoChen committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    0578364 View commit details
    Browse the repository at this point in the history
  2. triggers: fix address mcontrol/mcontrol6 on fetching PC

    The fetching PC is in refill_icache() instead of fetch_slow_path().
    This commit moves the address mcontrol/mcontrol6 checking from
    fetch_slow_path() to refill_icache() for the correct fetching PC.
    
    For example, consider a 4-byte instruction at PC=0x4000. The Debug
    specification recommends to compare PC={0x4000,0x4001,0x4002,0x4003};
    otherwise, the Debug specification requires to compare PC=0x4000. The
    previous implementation compares PC={0x4000,0x4002}, which is undesired.
    YenHaoChen committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    146e41e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0d8067b View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Configuration menu
    Copy the full SHA
    661c6a2 View commit details
    Browse the repository at this point in the history