triggers: implement {mcontrol,mcontrol6}.match = {not equal,not napot,not mask low,not mask high} #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…,not mask low,not mask high}
YenHaoChen
commented
May 4, 2023
There was a problem hiding this comment.
The encoding.h does not have MCONTROL_MATCH_NOT_EQUAL, MCONTROL_MATCH_NOT_NAPOT, MCONTROL_MATCH_NOT_MASK_LOW, MCONTROL_MATCH_NOT_MASK_HIGH. Without modifying encoding.h (or without including debug_defines.h), we must hardcode the values. However, that makes this part inconsistent. Should we also hardcode the values of MATCH_EQUAL, MATCH_NAPOT, MATCH_GE, MATCH_LT, MATCH_MASK_LOW, and MATCH_MASK_HIGH?
There was a problem hiding this comment.
What's the problem with including debug_defines.h? That seems easier to maintain, etc. Are there macro name conflicts?
|
@timsifive Would you share some words on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements {mcontrol,mcontrol6}.match = {not equal,not napot,not mask low,not mask high}.