-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci fix #514
Ci fix #514
Conversation
@jamesbeyond , @allenjbaum please review this one. This CI is passing all CI errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Seems CI still got some issues |
@UmerShahidengr I think this error come from pip3, |
Yes. I understood that problem, it was happening because riscv-isac and riscv-ctg were requiring different versions of pip libraries in their requirements.txt files. I have made those files consistent, upgraded some versions, and checked everything offline. After merging this PR, the CI will hopefully pass all tests. |
I have fixed the dependencies in CI.