Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci fix #514

Merged
merged 14 commits into from
Oct 9, 2024
Merged

Ci fix #514

merged 14 commits into from
Oct 9, 2024

Conversation

UmerShahidengr
Copy link
Collaborator

I have fixed the dependencies in CI.

@UmerShahidengr
Copy link
Collaborator Author

@jamesbeyond , @allenjbaum please review this one. This CI is passing all CI errors

Copy link
Collaborator

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesbeyond
Copy link
Collaborator

Seems CI still got some issues

@jamesbeyond
Copy link
Collaborator

@UmerShahidengr I think this error come from pip3,
please checkout this post, seems there are some workarounds:
https://stackoverflow.com/questions/75608323/how-do-i-solve-error-externally-managed-environment-every-time-i-use-pip-3

@UmerShahidengr
Copy link
Collaborator Author

Yes. I understood that problem, it was happening because riscv-isac and riscv-ctg were requiring different versions of pip libraries in their requirements.txt files. I have made those files consistent, upgraded some versions, and checked everything offline. After merging this PR, the CI will hopefully pass all tests.

@UmerShahidengr UmerShahidengr merged commit e6efcf0 into riscv-non-isa:dev Oct 9, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants