Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix download of stage2 image from .treeinfo #5773

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix download of stage2 image from .treeinfo #5773

wants to merge 2 commits into from

Commits on Jul 16, 2024

  1. Fix whitespace chars broke Dracut config parsing 

    With commit 0785531 the `get_config`
function in anaconda-lib.sh was broken because missing quotes removed
leading and trailing whitespace characters automatically but after the
fix in commit mentioned above this side effect was fixed which lead in
broken code. In other words the key were never matched because of
trailing whitespace.

Issue raised by this is not being able to read .treeinfo and .buildstamp
files in Dracut. Example of such situation is broken boot when stage2
image is stored under special path mentioned in .treeinfo file.

Resolves: RHEL-
    @jkonecny12
    jkonecny12 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2a2817e View commit details
    Browse the repository at this point in the history

  2. Fix trailing / when downloading stage2 image 

    In Dracut the URL concatenation from .treeinfo could also point you to
directory above by `..`. However, if the `inst.repo=` argument was
set with trailing `/` it will create URL which is not supported by curl.

Supported:
`os/../BaseOS/`
Unsupported by curl:
`os//../BaseOS/`

Remove the trailing `/` to avoid this issue.

Resolves: RHEL-48821
    @jkonecny12
    jkonecny12 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    89fd44c View commit details
    Browse the repository at this point in the history