Migrate the kickstart script commands #5739

adamkankovsky · 2024-07-03T06:22:01Z

Working with: #5775
Thanks @rvykydal.

pep8speaks · 2024-07-03T06:22:09Z

Hello @adamkankovsky! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-10-02 14:03:14 UTC

jkonecny12

Otherwise looks good to me so far.

jkonecny12 · 2024-07-11T10:57:55Z

pyanaconda/modules/runtime/scripts/Makefile.am

+scriptsdir = $(pkgpyexecdir)/modules/runtime/scripts
+dist_scripts_DATA = $(wildcard $(srcdir)/*.py)
+
+MAINTAINERCLEANFILES = Makefile.in


Suggested change

MAINTAINERCLEANFILES = Makefile.in

MAINTAINERCLEANFILES = Makefile.in

Add missing newline at the end of the file.

jkonecny12 · 2024-07-11T11:00:07Z

pyanaconda/modules/runtime/scripts/Makefile.am

+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+pkgpyexecdir = $(pyexecdir)/py$(PACKAGE_NAME)
+scriptsdir = $(pkgpyexecdir)/modules/runtime/scripts


I have a feeling that his will not work correctly. There is already scriptsdir variable (scripts/Makefile.am) and I have a feeling these are global. I'm not 100% sure how ti behaves so please make sure that your commit won't break automake and both directories are processed correctly by automake.

So far everything works as it should and there is no problem with the module

rvykydal · 2024-07-18T09:31:07Z

I'll just add link to my WIP before @adamkankovsky took over: #5775, may be useful for reference. (I used Katerina's WIP in the same way).
In my notes in 9d3fb85 I say %pre is most challenging, so maybe it is good to work on it first, like Adam does.

adamkankovsky · 2024-07-24T10:32:46Z

/kickstart-test --testtype smoke

adamkankovsky · 2024-07-24T13:23:31Z

/kickstart-test --testtype smoke

jkonecny12

Looks great otherwise.
Also please take a look on coverage. I'm surprised that for such a change we don't have any new tests.

jkonecny12 · 2024-07-24T14:18:43Z

pyanaconda/core/kickstart/scripts.py

+    execution.
+    Output is logged by the program logger, the path specified by --log
+    or to /tmp/ks-script-\\*.log
+    # TODORV return


I guess this is leftover.

jkonecny12 · 2024-07-24T14:21:05Z

pyanaconda/core/kickstart/scripts.py

@@ -0,0 +1,80 @@
+#
+# Commond utilities for working with scripts


Commond is typo?

jkonecny12 · 2024-07-24T14:25:51Z

pyanaconda/core/kickstart/specification.py

+        self.scripts = []
+


Why is this required?

Yes, because sections for scripts don't have a data parser like packages does, and sections themselves don't have an action to create an array for scitps. Therefore it is necessary to create it manually. It looks quite strange, but I spent a lot of time on this parsing and unfortunately I didn't come up with anything better using pykickstart

Could you please add comment explaining this?

jkonecny12 · 2024-07-24T14:38:07Z

pyanaconda/modules/runtime/scripts/scripts.py

+        for script in self._scripts:
+            if script.type == self._script_type:
+                if script.type == KS_SCRIPT_POST:
+                    script.run(conf.target.system_root)


If I'm reading this correctly then you are saying that post script is always run in chroot. That is not correct it depends on --nochroot parameter.

This is only the path which is used if --chroot is set. Default is always "/".

jkonecny12 · 2024-07-24T14:43:57Z

pyanaconda/modules/runtime/scripts/scripts.py

+__all__ = ["ScriptsModule"]
+
+
+class RunScriptsTask(Task):


Please separate this class into another file.

adamkankovsky · 2024-09-10T07:55:16Z

/kickstart-test --testtype smoke

adamkankovsky · 2024-09-26T12:00:04Z

/kickstart-test --kstest-pr 1302 --skip-testtypes whatever

jkonecny12

Looks much better. However, I don't almost any tests.

You are adding a new Task and a new module and none of these are covered by tests. Please take a look on test coverage to see what is missing.

pyanaconda/modules/runtime/scripts/runtime.py

jkonecny12

Looks great to me now. Thanks!

adamkankovsky temporarily deployed to gh-cockpituous July 3, 2024 06:22 — with GitHub Actions Inactive

adamkankovsky marked this pull request as draft July 3, 2024 06:22

github-actions bot added the f41 label Jul 3, 2024

jkonecny12 reviewed Jul 11, 2024

View reviewed changes

adamkankovsky force-pushed the migration-kickstart-scripts branch from c13788b to b039904 Compare July 22, 2024 13:41

adamkankovsky temporarily deployed to gh-cockpituous July 22, 2024 13:41 — with GitHub Actions Inactive

adamkankovsky force-pushed the migration-kickstart-scripts branch from b039904 to 2956709 Compare July 23, 2024 06:37

adamkankovsky temporarily deployed to gh-cockpituous July 23, 2024 06:37 — with GitHub Actions Inactive

adamkankovsky force-pushed the migration-kickstart-scripts branch from 2956709 to d7507b4 Compare July 23, 2024 08:38

adamkankovsky temporarily deployed to gh-cockpituous July 23, 2024 08:38 — with GitHub Actions Inactive

adamkankovsky force-pushed the migration-kickstart-scripts branch from d7507b4 to d5d17d6 Compare July 23, 2024 13:07

adamkankovsky temporarily deployed to gh-cockpituous July 23, 2024 13:07 — with GitHub Actions Inactive

adamkankovsky force-pushed the migration-kickstart-scripts branch from d5d17d6 to 305d912 Compare July 23, 2024 13:12

adamkankovsky had a problem deploying to gh-cockpituous July 23, 2024 13:12 — with GitHub Actions Failure

adamkankovsky marked this pull request as ready for review July 23, 2024 13:15

adamkankovsky force-pushed the migration-kickstart-scripts branch from 305d912 to 42c0b63 Compare July 24, 2024 07:43

adamkankovsky temporarily deployed to gh-cockpituous July 24, 2024 07:43 — with GitHub Actions Inactive

adamkankovsky changed the title ~~Migrate the %pre script~~ Migrate the kickstart script commands Jul 24, 2024

adamkankovsky requested a review from jkonecny12 July 24, 2024 10:32

adamkankovsky force-pushed the migration-kickstart-scripts branch from 42c0b63 to 1c4f683 Compare July 24, 2024 12:58

adamkankovsky temporarily deployed to gh-cockpituous July 24, 2024 12:59 — with GitHub Actions Inactive

jkonecny12 requested changes Jul 24, 2024

View reviewed changes

adamkankovsky force-pushed the migration-kickstart-scripts branch from 1c4f683 to 3184a63 Compare July 24, 2024 15:22

adamkankovsky temporarily deployed to gh-cockpituous July 24, 2024 15:22 — with GitHub Actions Inactive

adamkankovsky force-pushed the migration-kickstart-scripts branch from 3184a63 to 46062e2 Compare July 24, 2024 15:27

adamkankovsky had a problem deploying to gh-cockpituous July 24, 2024 15:27 — with GitHub Actions Failure

adamkankovsky force-pushed the migration-kickstart-scripts branch from a7facef to 1e5d0aa Compare September 10, 2024 07:45

adamkankovsky temporarily deployed to gh-cockpituous September 10, 2024 07:45 — with GitHub Actions Inactive

adamkankovsky force-pushed the migration-kickstart-scripts branch from 1e5d0aa to 6648dff Compare September 19, 2024 07:20

adamkankovsky temporarily deployed to gh-cockpituous September 19, 2024 07:20 — with GitHub Actions Inactive

adamkankovsky temporarily deployed to gh-cockpituous September 19, 2024 07:33 — with GitHub Actions Inactive

adamkankovsky mentioned this pull request Sep 19, 2024

Tests for kickstart script commands rhinstaller/kickstart-tests#1302

Open

adamkankovsky force-pushed the migration-kickstart-scripts branch from 6648dff to f8719ac Compare September 19, 2024 14:31

adamkankovsky temporarily deployed to gh-cockpituous September 19, 2024 14:31 — with GitHub Actions Inactive

adamkankovsky force-pushed the migration-kickstart-scripts branch from f8719ac to 4958c2f Compare September 24, 2024 08:25

adamkankovsky temporarily deployed to gh-cockpituous September 24, 2024 08:25 — with GitHub Actions Inactive

adamkankovsky force-pushed the migration-kickstart-scripts branch from 4958c2f to 01d0de6 Compare September 25, 2024 08:07

adamkankovsky temporarily deployed to gh-cockpituous September 25, 2024 08:07 — with GitHub Actions Inactive

jkonecny12 mentioned this pull request Sep 25, 2024

Add anaconda-tui package to updates-image rhinstaller/anaconda-webui#451

Merged

adamkankovsky requested review from rvykydal and jkonecny12 September 25, 2024 18:32

adamkankovsky force-pushed the migration-kickstart-scripts branch from 01d0de6 to 67cdc61 Compare September 26, 2024 07:07

adamkankovsky temporarily deployed to gh-cockpituous September 26, 2024 07:07 — with GitHub Actions Inactive

jkonecny12 requested changes Sep 26, 2024

View reviewed changes

pyanaconda/modules/runtime/scripts/runtime.py Outdated Show resolved Hide resolved

adamkankovsky force-pushed the migration-kickstart-scripts branch from 67cdc61 to a26706c Compare October 2, 2024 11:12

adamkankovsky temporarily deployed to gh-cockpituous October 2, 2024 11:12 — with GitHub Actions Inactive

adamkankovsky force-pushed the migration-kickstart-scripts branch from a26706c to 320ae7f Compare October 2, 2024 11:28

adamkankovsky temporarily deployed to gh-cockpituous October 2, 2024 11:28 — with GitHub Actions Inactive

adamkankovsky requested a review from jkonecny12 October 2, 2024 13:02

jkonecny12 approved these changes Oct 2, 2024

View reviewed changes

adamkankovsky added 2 commits October 2, 2024 16:02

Migrate the %pre-install, %post, %onerror and %traceback scripts

aa20e95

Test for kickstart scripts

e81a0b7

adamkankovsky force-pushed the migration-kickstart-scripts branch from 320ae7f to e81a0b7 Compare October 2, 2024 14:03

adamkankovsky temporarily deployed to gh-cockpituous October 2, 2024 14:03 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate the kickstart script commands #5739

Migrate the kickstart script commands #5739

adamkankovsky commented Jul 3, 2024 •

edited

Loading

pep8speaks commented Jul 3, 2024 •

edited

Loading

jkonecny12 left a comment

jkonecny12 Jul 11, 2024

jkonecny12 Jul 11, 2024

jkonecny12 Jul 11, 2024

adamkankovsky Jul 23, 2024

rvykydal commented Jul 18, 2024 •

edited

Loading

adamkankovsky commented Jul 24, 2024

adamkankovsky commented Jul 24, 2024

jkonecny12 left a comment

jkonecny12 Jul 24, 2024

jkonecny12 Jul 24, 2024

jkonecny12 Jul 24, 2024

adamkankovsky Jul 24, 2024

jkonecny12 Sep 26, 2024

jkonecny12 Jul 24, 2024

adamkankovsky Jul 24, 2024

jkonecny12 Jul 24, 2024

adamkankovsky commented Sep 10, 2024

adamkankovsky commented Sep 26, 2024

jkonecny12 left a comment

jkonecny12 left a comment

	MAINTAINERCLEANFILES = Makefile.in
	MAINTAINERCLEANFILES = Makefile.in

		@@ -0,0 +1,80 @@
		#
		# Commond utilities for working with scripts

Migrate the kickstart script commands #5739

Are you sure you want to change the base?

Migrate the kickstart script commands #5739

Conversation

adamkankovsky commented Jul 3, 2024 • edited Loading

pep8speaks commented Jul 3, 2024 • edited Loading

Comment last updated at 2024-10-02 14:03:14 UTC

jkonecny12 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rvykydal commented Jul 18, 2024 • edited Loading

adamkankovsky commented Jul 24, 2024

adamkankovsky commented Jul 24, 2024

jkonecny12 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adamkankovsky commented Sep 10, 2024

adamkankovsky commented Sep 26, 2024

jkonecny12 left a comment

Choose a reason for hiding this comment

jkonecny12 left a comment

Choose a reason for hiding this comment

adamkankovsky commented Jul 3, 2024 •

edited

Loading

pep8speaks commented Jul 3, 2024 •

edited

Loading

rvykydal commented Jul 18, 2024 •

edited

Loading