-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix python install and upgrade versions to allow 3.11 installation #374
base: master
Are you sure you want to change the base?
Conversation
e3fc6e0
to
733452a
Compare
MacOS works, tested on M1. Windows is now also working (amd64). Linux will follow. If you want to run this, set |
Hi @jmfrank63, |
@rmcpantoja Yes, you might be right. I gave it a try, it compiles and installs on macOS and Windows. The basic example works on both. But then I tried a Russian example on Windows and the result is just rubbish. This could be either to the fact that I had to use hex code points for getting it to compile or some other reason. We definitely need more tests. |
No, pytorch lightning It has nothing to do with installing piper_phonemice in Python, since they are different packages. pytorch lightning is only used by the piper_train package. If you want to support pl >2, you need to update the piper_train training code, especially using LightningCli instead of argparse. |
@synesthesiam thanks for all the hard work, but this is stopping me from using piper. Is this project unmaintained? |
Hello, would this PR fix the problem here #384, and if so how would i go about using this PR with a Python app using Piper? |
This PR contains a lot of unrelated changes. The changes to AFAIK, Windows doesn't have Because of the style changes it is difficult to detect if the content of |
Tested on a Mac M1. Should fix
pip install piper-tts
, which already created several issues.Upgraded several requirement versions.
Also fixed Readme formatting and changed
the teaser to reflect the python runnable command.