Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow checkout action and triggers #220

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

webbnh
Copy link
Contributor

@webbnh webbnh commented Oct 4, 2024

The current GitHub Action workflow for this repo is triggered only on pushes to the upstream repo. This means that it is not run, for instance, for pull requests from forks of this repo. And, that means that the results of the run cannot be used as a check on PRs.

This PR reworks the workflow triggers:

  • The workflow will now be triggered for pull requests. Once this is in place, we should get feedback in the PRs and be able to enable a rule for our favorite branches which blocks merges that do not pass the tests.
  • The workflow will now be triggered only for pushes to the main and legacy branches. This ensures that the results of merges still test properly. (Note that we can add additional branches here and/or use wildcards to select branches, but having both push and pull_request triggers results in redundant workflow executions if someone posts a PR from an upstream branch, which is why I've put this restriction in place -- let me know if you want this altered.)
  • The workflow will also trigger if we ever create any releases or other tags beginning with the letter v. This ensures that the releases still test properly. This is limited to "v"-tags, so that we are free to use labels without otherwise interacting with the CI.

This PR also brings the checkout action up to the latest version.

@Zyzyx
Copy link
Collaborator

Zyzyx commented Oct 4, 2024

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants