Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Fix definition of success in newXMLHttpRequestWithError #415

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

WIP: Fix definition of success in newXMLHttpRequestWithError #415

wants to merge 1 commit into from

Commits on Apr 27, 2021

  1. Fix definition of success in newXMLHttpRequestWithError 

    When ready state is DONE (4), we also needs to check its status to know if it
is success or not. According to MDN [1]:

  Before the request completes, the value of status is 0. Browsers also report a
  status of 0 in case of XMLHttpRequest errors.

[1]: https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/status
    @TheKK
    TheKK committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    badb942 View commit details
    Browse the repository at this point in the history