Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail safely when pickling #4085

Merged
merged 2 commits into from
Oct 7, 2024
Merged

fail safely when pickling #4085

merged 2 commits into from
Oct 7, 2024
+18 −9

Conversation

adhami3310
Copy link
Member

No description provided.

masenf
masenf approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but we can't just ignore redis pickling errors long term, that's going to create problems for people

@adhami3310
Copy link
Member Author

but we can't just ignore redis pickling errors

I think it makes sense here because it's going to show up during development, so people wouldn't be surprised when it doesn't work on redis.

@adhami3310 adhami3310 merged commit c7c830d into main Oct 7, 2024
39 checks passed
masenf pushed a commit that referenced this pull request Oct 7, 2024
@adhami3310 @masenf
fail safely when pickling (#4085)
3810161 
* fail safely when pickling

* why did i do that
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adhami3310 @masenf