Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build a patchQueriesData thunk to batch patching of endpoints #4110

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
91 changes: 53 additions & 38 deletions packages/toolkit/src/query/core/buildSlice.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,22 +127,28 @@ export function buildSlice({
},
prepare: prepareAutoBatched<QuerySubstateIdentifier>(),
},
queryResultPatched: {
queryResultsPatched: {
reducer(
draft,
{
payload: { queryCacheKey, patches },
payload,
}: PayloadAction<
QuerySubstateIdentifier & { patches: readonly Patch[] }
Array<QuerySubstateIdentifier & { patches: readonly Patch[] }>
>,
) {
updateQuerySubstateIfExists(draft, queryCacheKey, (substate) => {
substate.data = applyPatches(substate.data as any, patches.concat())
})
for (const { queryCacheKey, patches } of payload) {
updateQuerySubstateIfExists(draft, queryCacheKey, (substate) => {
substate.data = applyPatches(
substate.data as any,
patches.concat(),
)
})
}
},
prepare: prepareAutoBatched<
QuerySubstateIdentifier & { patches: readonly Patch[] }
>(),
prepare:
prepareAutoBatched<
Array<QuerySubstateIdentifier & { patches: readonly Patch[] }>
>(),
},
},
extraReducers(builder) {
Expand Down Expand Up @@ -330,39 +336,46 @@ export function buildSlice({
name: `${reducerPath}/invalidation`,
initialState: initialState as InvalidationState<string>,
reducers: {
updateProvidedBy: {
updateProvidedBys: {
reducer(
draft,
action: PayloadAction<{
queryCacheKey: QueryCacheKey
providedTags: readonly FullTagDescription<string>[]
}>,
action: PayloadAction<
Array<{
queryCacheKey: QueryCacheKey
providedTags: readonly FullTagDescription<string>[]
}>
>,
) {
const { queryCacheKey, providedTags } = action.payload

for (const tagTypeSubscriptions of Object.values(draft)) {
for (const idSubscriptions of Object.values(tagTypeSubscriptions)) {
const foundAt = idSubscriptions.indexOf(queryCacheKey)
if (foundAt !== -1) {
idSubscriptions.splice(foundAt, 1)
for (const { queryCacheKey, providedTags } of action.payload) {
for (const tagTypeSubscriptions of Object.values(draft)) {
for (const idSubscriptions of Object.values(
tagTypeSubscriptions,
)) {
const foundAt = idSubscriptions.indexOf(queryCacheKey)
if (foundAt !== -1) {
idSubscriptions.splice(foundAt, 1)
}
}
}
}

for (const { type, id } of providedTags) {
const subscribedQueries = ((draft[type] ??= {})[
id || '__internal_without_id'
] ??= [])
const alreadySubscribed = subscribedQueries.includes(queryCacheKey)
if (!alreadySubscribed) {
subscribedQueries.push(queryCacheKey)
for (const { type, id } of providedTags) {
const subscribedQueries = ((draft[type] ??= {})[
id || '__internal_without_id'
] ??= [])
const alreadySubscribed =
subscribedQueries.includes(queryCacheKey)
if (!alreadySubscribed) {
subscribedQueries.push(queryCacheKey)
}
}
}
},
prepare: prepareAutoBatched<{
queryCacheKey: QueryCacheKey
providedTags: readonly FullTagDescription<string>[]
}>(),
prepare: prepareAutoBatched<
Array<{
queryCacheKey: QueryCacheKey
providedTags: readonly FullTagDescription<string>[]
}>
>(),
},
},
extraReducers(builder) {
Expand Down Expand Up @@ -410,12 +423,14 @@ export function buildSlice({
)
const { queryCacheKey } = action.meta.arg

invalidationSlice.caseReducers.updateProvidedBy(
invalidationSlice.caseReducers.updateProvidedBys(
draft,
invalidationSlice.actions.updateProvidedBy({
queryCacheKey,
providedTags,
}),
invalidationSlice.actions.updateProvidedBys([
{
queryCacheKey,
providedTags,
},
]),
)
},
)
Expand Down
Loading
Loading