Skip to content

Commit

Permalink
Merge pull request #651 from aireilly/translate
Browse files Browse the repository at this point in the history
Rules typo fix "convert:transform" + correct virtual hard disk/floppy based on SSG guidance
  • Loading branch information
aireilly authored Sep 27, 2023
2 parents 89f0b6c + 9ef3974 commit 60abc8f
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 32 deletions.
8 changes: 3 additions & 5 deletions .vale/fixtures/RedHat/TermsErrors/testinvalid.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,6 @@ Firefox
first name
fixed disk drive
flavor
floppy
floppy disk
floppy drive
focussed
forename
forward compatible
Expand All @@ -183,7 +180,6 @@ grey
gzipped file
hard boot
hard copy
hard drive
hard file
hardcode
hardcoded
Expand Down Expand Up @@ -413,14 +409,16 @@ ToolTip
totalled
touch base
touchscreen
translate
trouble shoot
trust store
try and
twisty
TY-RAP
typo
unallocate
virtual diskette drive
virtual diskette
virtual hard disk
uncheck
uncompilation
uncompile
Expand Down
2 changes: 1 addition & 1 deletion .vale/fixtures/RedHat/TermsSuggestions/testvalid.adoc
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
64-bit x86
bare-metal clusters
bare-metal compute
bare-metal configuration
Expand Down Expand Up @@ -28,5 +29,4 @@ shell script
this clause that is restrictive
this clause, which is nonrestrictive
through
64-bit x86
x86_64
36 changes: 16 additions & 20 deletions .vale/styles/RedHat/TermsErrors.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,44 +8,37 @@ action:
name: replace
# swap maps tokens in form of bad: good
swap:
"(?<!-)healthcheck|health-check": health check
"(?<!-)pm": PM
"(?<!-|I )am": AM
"(?<!.)io": I/O
"(?<!as well )as per": according to|as|as in
"(?<!kernel )oops": kernel oops
"(?<!mobile |cell )phone": "telephone|cell phone|mobile phone"
"(?<!Mozilla )Firefox": Mozilla Firefox
"(?<!Mozilla )Thunderbird": Mozilla Thunderbird
"(?<!pseudo-)ops": operations
"(?<!self-)hosted engine|hosted-engine": self-hosted engine
"[bB]asic [aA]uth": Basic HTTP authentication|Basic authentication
"a lot(?: of)?": many|much
"AI": Assisted Installer
"best of breed|best-of-breed": best in class
"bottle neck|bottle-neck": bottleneck
"Christian name|forename|first name": given name
"down(?:-)?level": earlier|previous|not at the latest level
"IPI": installer-provisioned infrastructure
"pop-up (?:blocker|killer)": software to block pop-up ad windows
"re(?:-)?occur": recur
"sanity test|sanity check": test|evaluate|validate|verify
"single quote mark|single quote(?! mark)": single quotation mark
"sort(?:-|/)?merge": sort|merge
"top(?:-)?left": upper left|upper right|upper-left|upper-right
"top(?:-)?right": upper left|upper right|upper-left|upper-right
"UPI": user-provisioned infrastructure
"(?<!-)healthcheck|health-check": health check
"(?<!-)pm": PM
"(?<!-|I )am": AM
"(?<!.)io": I/O
'(?<!IBM\s)S\/390|S90|S\s390': IBM S/390
"(?<!pseudo-)ops": operations
"(?<!self-)hosted engine|hosted-engine": self-hosted engine
"(?<!virtual )floppy disk": diskette|diskette drive
"(?<!virtual )floppy drive": diskette|diskette drive
'(?<!virtual )floppy(?!\sdisk|\sdrive)': diskette|diskette drive
"(?<!virtual )hard drive": hard disk|hard disk drive
'backwards?\scompatible': compatible with earlier versions
"best of breed|best-of-breed": best in class
"Christian name|forename|first name": given name
'fixed\sdisk\sdrive': hard disk drive
"sanity test|sanity check": test|evaluate|validate|verify
"single quote mark|single quote(?! mark)": single quotation mark
"virtual diskette(?! drive)|virtual diskette drive": virtual floppy drive
'virtual\shard\sdisk': virtual hard drive
"w/(?!o) ": "with "
"w/o": without
'(?<!IBM\s)S\/390|S90|S\s390': IBM S/390
'backwards?\scompatible': compatible with earlier versions
10BASE-2: 10BASE2
10BASET: 10BASE-T
24/7: 24x7
Expand Down Expand Up @@ -200,6 +193,7 @@ swap:
fill in: complete|enter|specify
finalise: finalize
fire up: start
fixed disk drive: hard disk drive
flavor: version|method
focussed: focused
forward compatible: compatible with later versions
Expand Down Expand Up @@ -417,7 +411,6 @@ swap:
totalled: totaled
touch base: contact|communicate
touchscreen: touch-sensitive screen
translate: convert:transform
trouble shoot: troubleshoot
trust store: truststore
try and: try to
Expand All @@ -442,7 +435,10 @@ swap:
utilize: use
vanilla: uncustomized
versus: compared to
virtual diskette drive: virtual floppy drive
virtual diskette(?! drive): virtual floppy disk
virtual DOS machine: DOS session
virtual hard disk: virtual hard drive
virtual-equals-real: nonpageable
virtual-equals-virtual: pageable
wait condition: wait state
Expand Down
11 changes: 5 additions & 6 deletions .vale/styles/RedHat/TermsSuggestions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ action:
name: replace
swap:
"(?<!,) which": ", which| that"
"(?<!.-)jar": compress|archive
"(?<!by) using": " by using| that uses"
", that": ", which| that"
"[Bb]are metal(?= clusters?| compute| configuration| controls?| environments?| equipment| events?| hardware| hosts?| infrastructure| installations?| installers?| machines?| media| nodes?| provisioning| servers?| workers?)": bare-metal
Expand All @@ -17,13 +18,11 @@ swap:
"bottom(?:-)?right": lower right|lower-right
"shell(?! prompt| script)": shell prompt
"x64|x86-64|(?<!64-bit )x86": 64-bit x86|x86_64
'(?<!.-)jar': compress|archive
'(?<![\.\-])(?:zip|gzip|tar)(?! file| archive)': compress
'(?<!\.)tar file': '.tar file'
'(?<!\.)zip file': '.zip file'
'(?<!\.)tar file': ".tar file"
'(?<!\.)zip file': ".zip file"
above: later|previous|preceding
afterwards: afterward
afterwards: afterward
all caps: uppercase
below: earlier|later|following
bottom left: lower left
Expand All @@ -48,6 +47,6 @@ swap:
segfault: segmentation fault
spawn: create
start up: start
tarball: '.tar file'
tarball: ".tar file"
translate: convert|transform
via: through|by|from|on|by using
via: through|by|from|on|by using

0 comments on commit 60abc8f

Please sign in to comment.