Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation tests for tensorflow model gRPC RHOAIENG-9052 for triton #1844

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rpancham
Copy link
Contributor

Added Automation Test for RHOAIENG-13198

${INFERENCE_GRPC_INPUT_TENSORFLOW}= @tests/Resources/Files/triton/kserve-triton-tensorflow-gRPC-input.json
${TENSORFLOW_MODEL_NAME}= inception_graphdef
${TENSORFLOW_MODEL_LABEL}= inceptiongraphdef
${TENSORFLOW_RUNTIME_NAME}= triton-tensorflow-grpc

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${TENSORFLOW_RUNTIME_NAME}' is assigned but not used
@@ -152,6 +159,51 @@
... AND
... Delete Serving Runtime Template From CLI displayed_name=triton-kserve-grpc

Test Tensorflow Model Grpc Inference Via UI (Triton on Kserve) # robocop: off=too-long-test-case

Check warning

Code scanning / Robocop

Test case '{{ test_name }}' has too many keywords inside ({{ keyword_count }}/{{ max_allowed_count }}) Warning test

Test case 'Test Tensorflow Model Grpc Inference Via UI (Triton on Kserve)' has too many keywords inside (23/10)
... token=${TRUE}
Wait For Pods To Be Ready label_selector=serving.kserve.io/inferenceservice=${TENSORFLOW_MODEL_LABEL}
... namespace=${PRJ_TITLE}
${EXPECTED_INFERENCE_GRPC_OUTPUT_TENSORFLOW}= Load Json File file_path=${EXPECTED_INFERENCE_GRPC_OUTPUT_FILE_TENSORFLOW}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (132/120)
${EXPECTED_INFERENCE_GRPC_OUTPUT_TENSORFLOW}= Load Json File file_path=${EXPECTED_INFERENCE_GRPC_OUTPUT_FILE_TENSORFLOW}
... as_string=${TRUE}
${EXPECTED_INFERENCE_GRPC_OUTPUT_TENSORFLOW}= Load Json String ${EXPECTED_INFERENCE_GRPC_OUTPUT_TENSORFLOW}
${EXPECTED_INFERENCE_GRPC_OUTPUT_TENSORFLOW}= Evaluate json.dumps(${EXPECTED_INFERENCE_GRPC_OUTPUT_TENSORFLOW})

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (122/120)
Copy link
Contributor

github-actions bot commented Sep 21, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
546 0 0 546 100

@@ -39,6 +39,13 @@ ${PYTORCH_MODEL_NAME}= resnet50
${PYTORCH_RUNTIME_NAME}= triton-kserve-rest
${PYTORCH_RUNTIME_FILEPATH}= ${RESOURCES_DIRPATH}/triton_onnx_rest_servingruntime.yaml
${EXPECTED_INFERENCE_REST_OUTPUT_FILE_PYTORCH}= tests/Resources/Files/triton/kserve-triton-resnet-rest-output.json
${INFERENCE_GRPC_INPUT_TENSORFLOW}= @tests/Resources/Files/triton/kserve-triton-tensorflow-gRPC-input.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you could insert a reference to the model in the file name

${TENSORFLOW_RUNTIME_NAME}= triton-tensorflow-grpc
${TENSORFLOW_GRPC_RUNTIME_NAME}= triton-tensorflow-grpc
${TENSORFLOW_RUNTIME_FILEPATH}= ${RESOURCES_DIRPATH}/triton_tensorflow_gRPC_servingruntime.yaml
${EXPECTED_INFERENCE_GRPC_OUTPUT_FILE_TENSORFLOW}= tests/Resources/Files/triton/kserve-triton-inception_graphdef-gRPC-output.json

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (135/120)
@rpancham
Copy link
Contributor Author

rpancham commented Sep 23, 2024

Verified with Jenkins Build 581

@@ -0,0 +1,64 @@
apiVersion: serving.kserve.io/v1alpha1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems the same as https://github.com/red-hat-data-services/ods-ci/pull/1843/files
Can we avoid duplication and use one file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are adding this file because to test it on local without those files we cannot test them , once the all PR's are approved we remove the all the duplicate files

@@ -223,6 +224,12 @@
END
RETURN ${url}

Get Model Route for gRPC Via UI

Check warning

Code scanning / Robocop

Missing documentation in '{{ name }}' keyword Warning test

Missing documentation in 'Get Model Route for gRPC Via UI' keyword
@@ -223,6 +224,12 @@
END
RETURN ${url}

Get Model Route for gRPC Via UI
[Arguments] ${model_name}

Check warning

Code scanning / Robocop

Trailing whitespace at the end of line Warning test

Trailing whitespace at the end of line
${EXPECTED_INFERENCE_GRPC_OUTPUT_TENSORFLOW}= Evaluate json.dumps(${EXPECTED_INFERENCE_GRPC_OUTPUT_TENSORFLOW})
Log ${EXPECTED_INFERENCE_GRPC_OUTPUT_TENSORFLOW}
Open Model Serving Home Page
${host}= Get Model Route for gRPC Via UI model_name=${TENSORFLOW_MODEL_NAME}

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Get Model Route for gRPC Via UI' does not follow case convention
${EXPECTED_INFERENCE_GRPC_OUTPUT_TENSORFLOW}= Evaluate json.dumps(${EXPECTED_INFERENCE_GRPC_OUTPUT_TENSORFLOW})
Log ${EXPECTED_INFERENCE_GRPC_OUTPUT_TENSORFLOW}
Open Model Serving Home Page
${host}= Get Model Route for gRPC Via UI model_name=${TENSORFLOW_MODEL_NAME}

Check warning

Code scanning / Robocop

Trailing whitespace at the end of line Warning test

Trailing whitespace at the end of line
Open Model Serving Home Page
${host}= Get Model Route for gRPC Via UI model_name=${TENSORFLOW_MODEL_NAME}
Log ${host}
${token}= Get Access Token Via UI single_model=${TRUE} model_name=${TENSORFLOW_MODEL_NAME} project_name=${PRJ_TITLE}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (132/120)
@Raghul-M Raghul-M self-requested a review September 26, 2024 06:00
Copy link

sonarcloud bot commented Sep 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants