Add tests for hotfix 1.22.1 (#706)

* add tests and resources Signed-off-by: bdattoma <[email protected]> * remove wrong doc Signed-off-by: bdattoma <[email protected]> * fix robocop alerts Signed-off-by: bdattoma <[email protected]> * add polarion ID Signed-off-by: bdattoma <[email protected]> * fix robocop alerts Signed-off-by: bdattoma <[email protected]> * fix robocop alerts Signed-off-by: bdattoma <[email protected]> * fix reviews Signed-off-by: bdattoma <[email protected]> --------- Signed-off-by: bdattoma <[email protected]>
red-hat-data-services · Mar 3, 2023 · 02b79d6 · 02b79d6
1 parent 2383c83
commit 02b79d6
Show file tree

Hide file tree

Showing 4 changed files with 145 additions and 0 deletions.
diff --git a/tests/Resources/Files/expected_ctrl_np.txt b/tests/Resources/Files/expected_ctrl_np.txt
@@ -0,0 +1,17 @@
+{
+  "from": [
+    {
+      "namespaceSelector": {
+        "matchLabels": {
+          "kubernetes.io/metadata.name": "redhat-ods-applications"
+        }
+      }
+    }
+  ],
+  "ports": [
+    {
+      "port": 8888,
+      "protocol": "TCP"
+    }
+  ]
+}
diff --git a/tests/Resources/Files/expected_oauth_np.txt b/tests/Resources/Files/expected_oauth_np.txt
@@ -0,0 +1,8 @@
+{
+  "ports": [
+    {
+      "port": 8443,
+      "protocol": "TCP"
+    }
+  ]
+}
diff --git a/tests/Tests/100__deploy/100__installation/102__post_install.robot b/tests/Tests/100__deploy/100__installation/102__post_install.robot
@@ -281,6 +281,25 @@ Verify RHODS Display Name and Version
     Should Be Equal       ${rhods_version_t[1]}   ${rhods_version}   msg=RHODS vesrion and label is not consistent
     Should Be Equal       ${rhods_displayname}   Red Hat OpenShift Data Science  msg=Dieplay name doesn't match
 
+Verify RHODS Notebooks Network Policies
+    [Documentation]    Verifies that the network policies for RHODS Notebooks are present on the cluster
+    [Tags]    Smoke
+    ...       ODS-2045
+    Launch Notebook And Stop It
+    ${CR_name} =    Get User CR Notebook Name    username=${TEST_USER.USERNAME}
+    ${policy_ctrl} =    Run
+    ...    oc get networkpolicy ${CR_name}-ctrl-np -n rhods-notebooks -o json | jq '.spec.ingress[0]'
+    ${expected_policy_ctrl} =    Get File    tests/Resources/Files/expected_ctrl_np.txt
+    Should Be Equal As Strings    ${policy_ctrl}    ${expected_policy_ctrl}
+    Log    ${policy_ctrl}
+    Log    ${expected_policy_ctrl}
+    ${policy_oauth} =    Run
+    ...    oc get networkpolicy ${CR_name}-oauth-np -n rhods-notebooks -o json | jq '.spec.ingress[0]'
+    ${expected_policy_oauth} =    Get File    tests/Resources/Files/expected_oauth_np.txt
+    Should Be Equal As Strings    ${policy_oauth}    ${expected_policy_oauth}
+    Log    ${policy_oauth}
+    Log    ${expected_policy_oauth}
+
 
 *** Keywords ***
 Delete Dashboard Pods And Wait Them To Be Back
@@ -404,3 +423,18 @@ CUDA Teardown
     ...    during the cuda smoke verification
     Fix Spawner Status
     End Web Test
+
+Launch Notebook And Stop It    # robocop: disable
+    [Documentation]    Opens a Notebook, forcing the creation of the NetworkPolicies
+    Set Library Search Order    SeleniumLibrary
+    Open Browser    ${ODH_DASHBOARD_URL}    browser=${BROWSER.NAME}    options=${BROWSER.OPTIONS}
+    Login To RHODS Dashboard    ${TEST_USER.USERNAME}    ${TEST_USER.PASSWORD}    ${TEST_USER.AUTH_TYPE}
+    Wait For RHODS Dashboard To Load
+    Launch Jupyter From RHODS Dashboard Link
+    Login To Jupyterhub    ${TEST_USER.USERNAME}    ${TEST_USER.PASSWORD}    ${TEST_USER.AUTH_TYPE}
+    ${authorization_required} =    Is Service Account Authorization Required
+    IF    ${authorization_required}    Authorize Jupyterhub Service Account
+    Wait Until Page Contains    Start a notebook server
+    Fix Spawner Status
+    Spawn Notebook With Arguments    image=s2i-minimal-notebook
+    End Web Test
diff --git a/tests/Tests/500__jupyterhub/networkpolicy-test.robot b/tests/Tests/500__jupyterhub/networkpolicy-test.robot
@@ -0,0 +1,86 @@
+*** Settings ***
+Documentation    Test for the new Notebook network policies
+Resource         ../../Resources/ODS.robot
+Resource         ../../Resources/Common.robot
+Resource         ../../Resources/Page/ODH/JupyterHub/JupyterHubSpawner.robot
+Resource         ../../Resources/Page/ODH/JupyterHub/JupyterLabLauncher.robot
+Resource         ../../Resources/Page/ODH/JupyterHub/GPU.resource
+Library          JupyterLibrary
+Suite Setup      RHOSi Setup
+Suite Teardown   Network Policy Suite Teardown
+Force Tags       JupyterHub
+
+
+*** Test Cases ***
+Test Network Policy Effect
+    [Documentation]    Spawns two Notebooks with two different users and verifies
+    ...    That the new network policies prevent user2 from accessing user1's workspace
+    [Tags]  Sanity    Tier1
+    ...     ODS-2046
+    Open Browser And Start Notebook As First User
+    Open Browser And Start Notebook As Second User With Env Vars
+    Clone Git Repository And Run    https://github.com/redhat-rhods-qe/ods-ci-notebooks-main    ods-ci-notebooks-main/notebooks/500__jupyterhub/api/notebook_access.ipynb
+    Sleep  1
+    JupyterLab Code Cell Error Output Should Not Be Visible
+    Run Keyword And Continue On Failure    Run Additional Notebook Cells
+    End Web Test    username=${TEST_USER_2.USERNAME}
+    Switch Browser    ${first_browser_id}
+    End Web Test    username=${TEST_USER.USERNAME}
+
+
+*** Keywords ***
+Open Browser And Start Notebook As First User
+    [Documentation]    Opens a Notebook, forcing the creation of the NetworkPolicies
+    ...                and leaves it running
+    Set Library Search Order    SeleniumLibrary
+    Open Browser    ${ODH_DASHBOARD_URL}    browser=${BROWSER.NAME}    options=${BROWSER.OPTIONS}
+    Login To RHODS Dashboard    ${TEST_USER.USERNAME}    ${TEST_USER.PASSWORD}    ${TEST_USER.AUTH_TYPE}
+    Wait For RHODS Dashboard To Load
+    Launch Jupyter From RHODS Dashboard Link
+    Login To Jupyterhub    ${TEST_USER.USERNAME}    ${TEST_USER.PASSWORD}    ${TEST_USER.AUTH_TYPE}
+    ${authorization_required} =    Is Service Account Authorization Required
+    IF    ${authorization_required}    Authorize Jupyterhub Service Account
+    Wait Until Page Contains    Start a notebook server
+    Fix Spawner Status
+    Spawn Notebook With Arguments    image=s2i-minimal-notebook
+    @{old_browser} =    Get Browser Ids
+    ${first_browser_id} =    Set Variable    ${old_browser}[0]
+    Set Suite Variable    ${first_browser_id}
+    ${pod_name} =    Get User Notebook Pod Name    ${TEST_USER.USERNAME}
+    ${pod_ip} =    Run    oc get pod ${pod_name} -o jsonpath='{.status.podIP}' -n rhods-notebooks
+    Set Suite Variable    ${pod_ip}
+    ${pod_login_name} =    Get User CR Notebook Name    ${TEST_USER.USERNAME}
+    Set Suite Variable    ${pod_login_name}
+
+Open Browser And Start Notebook As Second User With Env Vars
+    [Documentation]    Opens a second Notebook, with pod details of the first notebook
+    Set Library Search Order    SeleniumLibrary
+    Open Browser    ${ODH_DASHBOARD_URL}    browser=${BROWSER.NAME}    options=${BROWSER.OPTIONS}
+    Login To RHODS Dashboard    ${TEST_USER_2.USERNAME}    ${TEST_USER_2.PASSWORD}    ${TEST_USER_2.AUTH_TYPE}
+    Wait For RHODS Dashboard To Load
+    Launch Jupyter From RHODS Dashboard Link
+    Login To Jupyterhub    ${TEST_USER_2.USERNAME}    ${TEST_USER_2.PASSWORD}    ${TEST_USER_2.AUTH_TYPE}
+    ${authorization_required} =    Is Service Account Authorization Required
+    IF    ${authorization_required}    Authorize Jupyterhub Service Account
+    Wait Until Page Contains    Start a notebook server
+    Fix Spawner Status
+    &{first_pod_details} =  Create Dictionary  pod_ip=${pod_ip}  pod_login=${pod_login_name}
+    Spawn Notebook With Arguments    image=s2i-minimal-notebook    username=${TEST_USER_2.USERNAME}
+    ...    password=${TEST_USER_2.PASSWORD}    auth_type=${TEST_USER_2.AUTH_TYPE}    envs=&{first_pod_details}
+
+Run Additional Notebook Cells
+    [Documentation]    Finalize attack notebook cells
+    ${pod_name_user2} =    Get User Notebook Pod Name    ${TEST_USER_2.USERNAME}
+    ${pod_ip_user2} =    Run    oc get pod ${pod_name_user2} -o jsonpath='{.status.podIP}' -n rhods-notebooks
+    ${tmp} =    Run Cell And Get Output    my_pod_ip='${pod_ip_user2}'
+    ${tmp2} =    Run Cell And Get Output    server_ips = scan_pods()
+    ${out1} =    Run Cell And Get Output    check_jupyter_logins(server_ips)
+    Should Be Equal    ${out1}    No Jupyter pods found
+    ${out2} =    Run Cell And Get Output    print_tree_view('/')
+    Should Be Equal    ${out2}    Server did not respond after 10 seconds, assuming connection is blocked
+
+Network Policy Suite Teardown
+    [Documentation]    Suite teardown to close remaining notebook servers and running
+    ...                RHOSi teardown
+    End Web Test
+    RHOSi Teardown