Build: use actual git identifier for READTHEDOCS_GIT_IDENTIFIER #11875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
commented
Dec 24, 2024
| @@ -478,29 +478,6 @@ def test_list_user_created_latest_and_stable_versions_in_default_branch_choices( | |||
| ], | |||
| ) | |||
|
|
|||
| def test_commit_name_not_in_default_branch_choices(self): | |||
There was a problem hiding this comment.
this test wasn't needed, we already test that only an exact list of the expected branches is included above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A commit can point to more than one branch/tag, so using git describe/name-rev or similar doesn't work reliably. Since we already have the tag/branch name for most of the versions (verbose_name), we can just use that, there are only three special cases:
commit_namewas doing exactly that, except for stable, so I went ahead and renamed it and refactored it (we were no longer using it) to use it in our API, so builders have access to it.Closes #11662