Default latest and non-stable notifications to off #11874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These feel like really aggressive defaults for something that will show on most versions. I think this is part of what people are disliking about the new notifications, and I'm not really sure why we defaulted them on, but I'd like to stop the UX issues here if we can.
ericholscher
commented
Dec 24, 2024
Comment on lines
+241
to
+242
| notifications_show_on_latest = models.BooleanField(default=False) | ||
| notifications_show_on_non_stable = models.BooleanField(default=False) |
There was a problem hiding this comment.
This is a place where I wish we had some kind of null default, because there's no way to write a migration that migrates this for folks that wanted to specify on in some fashion, but I think that's OK?
There was a problem hiding this comment.
Last time I wrote a queryset where I assumed if the modified and created dates are the same, then it wasn't changed by the user, but here I guess it may be surprising for some people that actually want this on, but maybe they just didn't know they could turn it off.
There was a problem hiding this comment.
I don't think we have modified data on the booleans though, only the overall model which has a bunch of unrelated stuff on it :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These feel like really aggressive defaults for something that will show on most versions.
I think this is part of what people are disliking about the new notifications,
and I'm not really sure why we defaulted them on,
but I'd like to stop the UX issues here if we can.