Config: inherit all pydantic models from a common base class #11857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
reviewed
Dec 16, 2024
| from pydantic import BaseModel, ConfigDict | ||
|
|
||
|
|
||
| class Parent(BaseModel): |
There was a problem hiding this comment.
I wouldn't name it Parent but something with a more explicit meaning. Maybe something like BaseConfigKey.
There was a problem hiding this comment.
Could be BaseModel too, and import pydantic's BaseModel with a different name
There was a problem hiding this comment.
No need to re-use a name that already exists if we can use a new one more explicit 😉
There was a problem hiding this comment.
Well, BaseModel it's what we want, so what about ParentModel?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.