Add native types to public API

reactphp · Jul 8, 2024 · a695ad1 · a695ad1
1 parent f2fb5a2
commit a695ad1
Show file tree

Hide file tree

Showing 8 changed files with 79 additions and 79 deletions.
diff --git a/src/ExtEvLoop.php b/src/ExtEvLoop.php
@@ -71,7 +71,7 @@ public function __construct()
         $this->signals = new SignalsHandler();
     }
 
-    public function addReadStream($stream, $listener)
+    public function addReadStream($stream, callable $listener): void
     {
         $key = (int)$stream;
 
@@ -97,7 +97,7 @@ private function getStreamListenerClosure($stream, $listener)
         };
     }
 
-    public function addWriteStream($stream, $listener)
+    public function addWriteStream($stream, callable $listener): void
     {
         $key = (int)$stream;
 
@@ -110,7 +110,7 @@ public function addWriteStream($stream, $listener)
         $this->writeStreams[$key] = $event;
     }
 
-    public function removeReadStream($stream)
+    public function removeReadStream($stream): void
     {
         $key = (int)$stream;
 
@@ -122,7 +122,7 @@ public function removeReadStream($stream)
         unset($this->readStreams[$key]);
     }
 
-    public function removeWriteStream($stream)
+    public function removeWriteStream($stream): void
     {
         $key = (int)$stream;
 
@@ -134,7 +134,7 @@ public function removeWriteStream($stream)
         unset($this->writeStreams[$key]);
     }
 
-    public function addTimer($interval, $callback)
+    public function addTimer(float $interval, callable $callback): TimerInterface
     {
         $timer = new Timer($interval, $callback, false);
 
@@ -152,7 +152,7 @@ public function addTimer($interval, $callback)
         return $timer;
     }
 
-    public function addPeriodicTimer($interval, $callback)
+    public function addPeriodicTimer(float $interval, callable $callback): TimerInterface
     {
         $timer = new Timer($interval, $callback, true);
 
@@ -166,7 +166,7 @@ public function addPeriodicTimer($interval, $callback)
         return $timer;
     }
 
-    public function cancelTimer(TimerInterface $timer)
+    public function cancelTimer(TimerInterface $timer): void
     {
         if (!isset($this->timers[$timer])) {
             return;
@@ -177,12 +177,12 @@ public function cancelTimer(TimerInterface $timer)
         $this->timers->detach($timer);
     }
 
-    public function futureTick($listener)
+    public function futureTick(callable $listener): void
     {
         $this->futureTickQueue->add($listener);
     }
 
-    public function run()
+    public function run(): void
     {
         $this->running = true;
 
@@ -207,7 +207,7 @@ public function run()
         }
     }
 
-    public function stop()
+    public function stop(): void
     {
         $this->running = false;
     }
@@ -228,7 +228,7 @@ public function __destruct()
         }
     }
 
-    public function addSignal($signal, $listener)
+    public function addSignal(int $signal, callable $listener): void
     {
         $this->signals->add($signal, $listener);
 
@@ -239,7 +239,7 @@ public function addSignal($signal, $listener)
         }
     }
 
-    public function removeSignal($signal, $listener)
+    public function removeSignal(int $signal, callable $listener): void
     {
         $this->signals->remove($signal, $listener);
 

diff --git a/src/ExtEventLoop.php b/src/ExtEventLoop.php
@@ -71,7 +71,7 @@ public function __destruct()
         $this->writeEvents = [];
     }
 
-    public function addReadStream($stream, $listener)
+    public function addReadStream($stream, callable $listener): void
     {
         $key = (int) $stream;
         if (isset($this->readListeners[$key])) {
@@ -88,7 +88,7 @@ public function addReadStream($stream, $listener)
         $this->readRefs[$key] = $stream;
     }
 
-    public function addWriteStream($stream, $listener)
+    public function addWriteStream($stream, callable $listener): void
     {
         $key = (int) $stream;
         if (isset($this->writeListeners[$key])) {
@@ -105,7 +105,7 @@ public function addWriteStream($stream, $listener)
         $this->writeRefs[$key] = $stream;
     }
 
-    public function removeReadStream($stream)
+    public function removeReadStream($stream): void
     {
         $key = (int) $stream;
 
@@ -119,7 +119,7 @@ public function removeReadStream($stream)
         }
     }
 
-    public function removeWriteStream($stream)
+    public function removeWriteStream($stream): void
     {
         $key = (int) $stream;
 
@@ -133,7 +133,7 @@ public function removeWriteStream($stream)
         }
     }
 
-    public function addTimer($interval, $callback)
+    public function addTimer(float $interval, callable $callback): TimerInterface
     {
         $timer = new Timer($interval, $callback, false);
 
@@ -142,7 +142,7 @@ public function addTimer($interval, $callback)
         return $timer;
     }
 
-    public function addPeriodicTimer($interval, $callback)
+    public function addPeriodicTimer(float $interval, callable $callback): TimerInterface
     {
         $timer = new Timer($interval, $callback, true);
 
@@ -151,20 +151,20 @@ public function addPeriodicTimer($interval, $callback)
         return $timer;
     }
 
-    public function cancelTimer(TimerInterface $timer)
+    public function cancelTimer(TimerInterface $timer): void
     {
         if ($this->timerEvents->contains($timer)) {
             $this->timerEvents[$timer]->free();
             $this->timerEvents->detach($timer);
         }
     }
 
-    public function futureTick($listener)
+    public function futureTick(callable $listener): void
     {
         $this->futureTickQueue->add($listener);
     }
 
-    public function addSignal($signal, $listener)
+    public function addSignal(int $signal, callable $listener): void
     {
         $this->signals->add($signal, $listener);
 
@@ -174,7 +174,7 @@ public function addSignal($signal, $listener)
         }
     }
 
-    public function removeSignal($signal, $listener)
+    public function removeSignal(int $signal, callable $listener): void
     {
         $this->signals->remove($signal, $listener);
 
@@ -184,7 +184,7 @@ public function removeSignal($signal, $listener)
         }
     }
 
-    public function run()
+    public function run(): void
     {
         $this->running = true;
 
@@ -202,7 +202,7 @@ public function run()
         }
     }
 
-    public function stop()
+    public function stop(): void
     {
         $this->running = false;
     }

diff --git a/src/ExtUvLoop.php b/src/ExtUvLoop.php
@@ -58,7 +58,7 @@ public function getUvLoop()
     /**
      * {@inheritdoc}
      */
-    public function addReadStream($stream, $listener)
+    public function addReadStream($stream, callable $listener): void
     {
         if (isset($this->readStreams[(int) $stream])) {
             return;
@@ -71,7 +71,7 @@ public function addReadStream($stream, $listener)
     /**
      * {@inheritdoc}
      */
-    public function addWriteStream($stream, $listener)
+    public function addWriteStream($stream, callable $listener): void
     {
         if (isset($this->writeStreams[(int) $stream])) {
             return;
@@ -84,7 +84,7 @@ public function addWriteStream($stream, $listener)
     /**
      * {@inheritdoc}
      */
-    public function removeReadStream($stream)
+    public function removeReadStream($stream): void
     {
         if (!isset($this->streamEvents[(int) $stream])) {
             return;
@@ -97,7 +97,7 @@ public function removeReadStream($stream)
     /**
      * {@inheritdoc}
      */
-    public function removeWriteStream($stream)
+    public function removeWriteStream($stream): void
     {
         if (!isset($this->streamEvents[(int) $stream])) {
             return;
@@ -110,7 +110,7 @@ public function removeWriteStream($stream)
     /**
      * {@inheritdoc}
      */
-    public function addTimer($interval, $callback)
+    public function addTimer(float $interval, callable $callback): TimerInterface
     {
         $timer = new Timer($interval, $callback, false);
 
@@ -137,7 +137,7 @@ public function addTimer($interval, $callback)
     /**
      * {@inheritdoc}
      */
-    public function addPeriodicTimer($interval, $callback)
+    public function addPeriodicTimer(float $interval, callable $callback): TimerInterface
     {
         $timer = new Timer($interval, $callback, true);
 
@@ -161,7 +161,7 @@ public function addPeriodicTimer($interval, $callback)
     /**
      * {@inheritdoc}
      */
-    public function cancelTimer(TimerInterface $timer)
+    public function cancelTimer(TimerInterface $timer): void
     {
         if (isset($this->timers[$timer])) {
             @\uv_timer_stop($this->timers[$timer]);
@@ -172,12 +172,12 @@ public function cancelTimer(TimerInterface $timer)
     /**
      * {@inheritdoc}
      */
-    public function futureTick($listener)
+    public function futureTick(callable $listener): void
     {
         $this->futureTickQueue->add($listener);
     }
 
-    public function addSignal($signal, $listener)
+    public function addSignal(int $signal, callable $listener): void
     {
         $this->signals->add($signal, $listener);
 
@@ -189,7 +189,7 @@ public function addSignal($signal, $listener)
         }
     }
 
-    public function removeSignal($signal, $listener)
+    public function removeSignal(int $signal, callable $listener): void
     {
         $this->signals->remove($signal, $listener);
 
@@ -202,7 +202,7 @@ public function removeSignal($signal, $listener)
     /**
      * {@inheritdoc}
      */
-    public function run()
+    public function run(): void
     {
         $this->running = true;
 
@@ -233,7 +233,7 @@ public function run()
     /**
      * {@inheritdoc}
      */
-    public function stop()
+    public function stop(): void
     {
         $this->running = false;
     }