Enable FutureWarnings and DeprecationWarnings as errors in cugraph #4271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
changed the title
BradReesWork
added
improvement
This was referenced Apr 29, 2024
This was referenced May 3, 2024
rapids-bot bot
pushed a commit
that referenced
this pull request
May 8, 2024
xref #4271 `chunksize` was deprecated in favor of `blocksize` Also removed an unsupported `chunksize` in a `cudf.read_csv` call Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Don Acosta (https://github.com/acostadon) - Rick Ratzel (https://github.com/rlratzel) URL: #4379
rapids-bot bot
pushed a commit
that referenced
this pull request
May 11, 2024
Broken off from #4271 Appears this was deprecated in favor of `induced_subgraph` Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Rick Ratzel (https://github.com/rlratzel) URL: #4386
rapids-bot bot
pushed a commit
that referenced
this pull request
May 11, 2024
xref #4271 For methods/parameters that are deprecated, ensures the doctests will pass if `FutureWarning` or `DeprecationWarning` are made as errors Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Rick Ratzel (https://github.com/rlratzel) URL: #4380
|
closing in favor of #4415 |
rapids-bot bot
pushed a commit
that referenced
this pull request
May 20, 2024
…4415) Supersedes #4271 There are some tests and internal usages of APIs that emit these warnings still. I don't know the best way to handle these warnings, but this PR ensures that _new_ `FutureWarning`s and `DeprecationWarning`s will raise an error in the CI Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Rick Ratzel (https://github.com/rlratzel) URL: #4415
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4223 and rapidsai/build-planning#26, cugraph tests will fail if a
FutureWarningorDeprecationWarningis raised