Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docstrings and test for strings.convert_durations APIs for pylibcudf #16982

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Add docstrings and test for strings.convert_durations APIs for pylibcudf #16982

merged 5 commits into from
Oct 4, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Contributes to #15162

Since the implementation already existed:

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package labels Oct 2, 2024
@mroeschke mroeschke requested a review from a team as a code owner October 2, 2024 21:04
@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 2, 2024
@mroeschke mroeschke mentioned this pull request Oct 2, 2024
Open
vyasr
vyasr approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change otherwise LGTM.

python/pylibcudf/pylibcudf/strings/convert/convert_durations.pyx
@@ -15,27 +15,80 @@ from pylibcudf.types import DataType
cpdef Column to_durations(
Column input,
DataType duration_type,
const string& format
str format
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, sorry we missed this on review.

python/pylibcudf/pylibcudf/tests/test_string_convert_durations.py Outdated Show resolved Hide resolved
python/pylibcudf/pylibcudf/tests/test_string_convert_durations.py Outdated Show resolved Hide resolved
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 77f3a5d into rapidsai:branch-24.12 Oct 4, 2024
99 checks passed
@mroeschke mroeschke deleted the pylibcudf/strings/convert2 branch October 4, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@Matt711 Matt711 Awaiting requested review from Matt711 Matt711 is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
pylibcudf
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @vyasr