Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add polars to "all" dependency list. #16875

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Add polars to "all" dependency list. #16875

merged 5 commits into from
Sep 25, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Sep 23, 2024

Description

This adds Polars to the "all" dependency list, ensuring that devcontainers and developers using the conda environment can use the Polars GPU backend provided by cudf.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner September 23, 2024 17:42
@bdice bdice requested a review from AyodeAwe September 23, 2024 17:42
@bdice bdice added feature request New feature or request non-breaking Non-breaking change labels Sep 23, 2024
@bdice bdice mentioned this pull request Sep 24, 2024
Merged
@bdice
Copy link
Contributor Author

bdice commented Sep 25, 2024

/merge

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Sep 25, 2024
galipremsagar
galipremsagar approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wence- Made a recent change in 4160423 making polars 1.8 the minimum so I updated the pins here.

@galipremsagar galipremsagar self-assigned this Sep 25, 2024
@rapids-bot rapids-bot bot merged commit e42b91b into rapidsai:branch-24.10 Sep 25, 2024
100 checks passed
@galipremsagar
Copy link
Contributor

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@AyodeAwe AyodeAwe Awaiting requested review from AyodeAwe AyodeAwe is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @galipremsagar @vyasr