Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection issue with the charts dropdown #12280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

momesgin
Copy link
Member

Summary

Fixes #12273

Technical notes summary

As discussed with @codyrancher we probably don't want the emits array at all in vue-select-overrides.js. It does all the emitting on a vue instance that gets passed to the mappedKeys method.

Areas or cases that should be tested

Local -> Apps -> Charts
Click "All" dropdown
Try unselecting any item

Areas which could experience regressions

n/a

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@momesgin momesgin added this to the v2.10.0 milestone Oct 16, 2024
@momesgin momesgin self-assigned this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue 3: Charts dropdown items can't be unselected
2 participants