Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom positioning of tooltip arrows #12264

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Oct 15, 2024

Summary

This removes custom positioning of tooltip arrows that appears to have been causing regressions in tooltip arrow styles dependent upon placement.

Fixes #12197

Occurred changes and/or fixed issues

  • Remove css attributes related to positioning for tooltip arrow and arrow container

Technical notes summary

I can assume that this was broken across the board with previous versions of v-tooltip, but these styles appear to be no longer needed now that we have migrated to floating-vue.

Areas or cases that should be tested

These are global styles that affect all tooltips used throughout dashboard.

Areas which could experience regressions

The scope of this changes addresses all tooltips. We will want to confirm that arrows are properly located for tooltips that render

  • to the top
  • to the bottom
  • to the left
  • to the right
  • a large amount of content
  • a small amount of content

Screenshot/Video

Common tooltips rendered on screen

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rak-phillip rak-phillip self-assigned this Oct 15, 2024
@rak-phillip rak-phillip added this to the v2.10.0 milestone Oct 15, 2024
@rak-phillip rak-phillip merged commit c8e9aeb into rancher:master Oct 15, 2024
39 checks passed
@rak-phillip rak-phillip deleted the bugfix/12197-tooltip-arrow branch October 15, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue3: Resource Lists: Tooltip arrow separated from the tooltip's body in resource lists
2 participants