update vsphere machine config to use new networks endpoint #12263
+140
−98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9817
Fixes #12271
Occurred changes and/or fixed issues
This PR updates the vsphere machine config to use networks'
moid
instead ofname
. This requires the use a new endpoint for networks,meta/vsphere/networks-extended
, which contains extra information.Technical notes summary
This PR also corrects a reactivity issue in ArrayList:
Screen.Recording.2024-10-15.at.8.38.12.AM.mov
Areas or cases that should be tested
Create an RKE2 vsphere cluster and verify that:
Create an RKE2 vsphere cluster with at least 1 network and 'vapp' auto mode selected ('Use vapp to configure networks with network protocol profiles'), verify that the save request vapp properties reference the network name, not full path (and not moid), see #12271 (comment)
I only had 1 network in my test environment so I added fake ones in the loadNetworks method to verify that I could add/remove different networks:
Checklist