Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RKE1 upgrading via template #12177

Merged

Conversation

mantis-toboggan-md
Copy link
Member

@mantis-toboggan-md mantis-toboggan-md commented Oct 8, 2024

Summary

Fixes #11874

Technical notes summary

The dashboard is setting the wrong value for the provider query param when loading some ember pages. It looks like the bug came in here https://github.com/rancher/dashboard/pull/9868/files#diff-9be0247bdd17368e0b020b8ab4933b0c53f2f4bbdb0b1936066fa67703e519d4R91

It seems that #11874 is happening because when a new cluster template revision is selected, some ember components re-initialize, and at that second partial load, the incorrect provider query param causes ember to not load rke1 form components. There's probably something messy going on over in Ember, but fixing the query param being sent over seems the safest solution, vs digging into ember route-changing logic.

Areas or cases that should be tested

Verify that the right create/edit pages load for the following cluster types:

  • RKE1 custom
  • RKE2 custom
  • RKE1 provisioned
  • RKE2 provisioned
  • Generic imported
  • AKS/EKS/GKE imported (1 of the 3)
  • AKS/EKS/GKE provisioned (1 of the 3)

For RKE1 clusters, verify that when using an RKE1 template users can select new template versions and the form is updated accordingly

Areas which could experience regressions

  • Creating/editing any cluster types that use ember pages
  • the 'provider' column in the cluster list

Screenshot/Video

this pr:
Screenshot 2024-10-08 at 10 47 49 AM

release-2.9:
Screenshot 2024-10-08 at 10 47 42 AM

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@mantis-toboggan-md mantis-toboggan-md added this to the v2.10.0 milestone Oct 8, 2024
@mantis-toboggan-md mantis-toboggan-md changed the title fix ember provider query param Fix RKE1 upgrading via template Oct 8, 2024
Copy link
Member

@eva-vashkevich eva-vashkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mantis-toboggan-md mantis-toboggan-md merged commit 5e55136 into rancher:master Oct 8, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [v2.9.1] Can not upgrade downstream cluster to new RKE template revision
2 participants