Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11874
Technical notes summary
The dashboard is setting the wrong value for the
provider
query param when loading some ember pages. It looks like the bug came in here https://github.com/rancher/dashboard/pull/9868/files#diff-9be0247bdd17368e0b020b8ab4933b0c53f2f4bbdb0b1936066fa67703e519d4R91It seems that #11874 is happening because when a new cluster template revision is selected, some ember components re-initialize, and at that second partial load, the incorrect
provider
query param causes ember to not load rke1 form components. There's probably something messy going on over in Ember, but fixing the query param being sent over seems the safest solution, vs digging into ember route-changing logic.Areas or cases that should be tested
Verify that the right create/edit pages load for the following cluster types:
For RKE1 clusters, verify that when using an RKE1 template users can select new template versions and the form is updated accordingly
Areas which could experience regressions
Screenshot/Video
this pr:
release-2.9:
Checklist