Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade vuedraggable to Vue3 version #12160

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

torchiaf
Copy link
Member

@torchiaf torchiaf commented Oct 7, 2024

Summary

Fixes #12141

Occurred changes and/or fixed issues

Technical notes summary

harvester.vue contains a <vuedraggable> element which is not compatible with Vue3.

When navigating to the Harvester cluster's creation page, it gets an error:

image

and loads the Custom cluster form as fallback.

We are upgrading vuedraggable dependency and usage to be compatible with Vue3.

Areas or cases that should be tested

  • Harvester cluster's volumes details. Drag & drop should work properly.

Areas which could experience regressions

  • Any Vue3 extension or Vue2 extension planned to be migrated to Vue3 that imports vuedraggable dep. from the shell (once a new shell version is released).

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@torchiaf torchiaf added this to the v2.10.0 milestone Oct 7, 2024
@torchiaf torchiaf changed the title Upgrade vuedraggable to Vue3 version Upgrade vuedraggable to Vue3 version Oct 7, 2024
@torchiaf torchiaf merged commit 1e8da03 into rancher:master Oct 8, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Harvester clusters page contains the Custom Clusters form
2 participants