Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix continuous integration #192

Merged
merged 16 commits into from
Apr 29, 2024
Merged

Fix continuous integration #192

merged 16 commits into from
Apr 29, 2024

Conversation

amontoison
Copy link
Member

Update the build for Apple Silicon.

cc @jfowkes

@jfowkes
Copy link
Contributor

jfowkes commented Apr 29, 2024

@amontoison this currently breaks the macOS tests, any idea why or how to fix?

@amontoison
Copy link
Member Author

@amontoison this currently breaks the macOS tests, any idea why or how to fix?

The issue is related to new headers in Xcode.
Can you try to compile SPRAL on your computer?

@jfowkes
Copy link
Contributor

jfowkes commented Apr 29, 2024

@amontoison can we switch to using homebrew for the macOS meson tests (see auto tools.yml)and install openblas and hwloc that way? The macOS meson tests are failing because openblas is not being found.

@jfowkes
Copy link
Contributor

jfowkes commented Apr 29, 2024

@amontoison the other macOS test are failing on the following GCC bug:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114007
We will have to wait until GCC 13.3 is available before merging this PR.

@amontoison
Copy link
Member Author

@amontoison can we switch to using homebrew for the macOS meson tests (see auto tools.yml)and install openblas and hwloc that way? The macOS meson tests are failing because openblas is not being found.

@jfowkes I don't see this issue with CI builds.
It seems that GitHub Actions also switched to Apple Silicon for Mac builds.
Maybe we should not use macos-latest but an older one, what do you think?

@jfowkes
Copy link
Contributor

jfowkes commented Apr 29, 2024

@amontoison yeah it's a right mess, can we switch back to macos-13? And the same for CIrrus (whatever they call macOS 13)?

@jfowkes
Copy link
Contributor

jfowkes commented Apr 29, 2024

@amontoison FYI macOS versions:

  • Monterey == 12
  • Ventura == 13
  • Sonoma == 14

@amontoison
Copy link
Member Author

Using MacOS ventura fixed the issue with CirrusCI.
I think that Monterey was removed and they installed MacOS Sonoma as fallback.

@jfowkes
Copy link
Contributor

jfowkes commented Apr 29, 2024

Okay so guess we should use Ventura (13) for autotools.yml and meson.yml?

@amontoison
Copy link
Member Author

@jfowkes
The flag -Wl,-ld_classic that you added fixes the issue in autotools.yml.
We need to add it in the Meson build system.

@jfowkes
Copy link
Contributor

jfowkes commented Apr 29, 2024

@amontoison sure just do:

-Dfortran_link_args='-Wl,-ld_classic'

should be correct according to the Meson docs.

@amontoison amontoison requested a review from jfowkes April 29, 2024 15:53
@amontoison
Copy link
Member Author

amontoison commented Apr 29, 2024

@jfowkes All tests passes 🎉 🎉
You probably need to do the same modifications in the other GitHub repositories of ralna (GALAHAD, ArchDefs, CUTEst).

@amontoison amontoison changed the title Update .cirrus.yml Fix continuous integration Apr 29, 2024
@jfowkes
Copy link
Contributor

jfowkes commented Apr 29, 2024

@amontoison yes Nick is struggling with fixing the GALAHAD CI and could use some help!

@jfowkes jfowkes merged commit 187cc21 into master Apr 29, 2024
16 checks passed
@jfowkes jfowkes deleted the amontoison-patch-1 branch April 29, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants