Use malloc and variably-modified types for SSMFE C interface tests and examples #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, the tests ran out of stack space with the many variable-length arrays on the stack, so replacing with malloc. To still be able to do all the matrix indexing, we use variably-modified types. That requires dereferencing to be added in many places and makes the syntax a bit unfamiliar, but it does avoid having to do the indexing manually.
Same as 92e1184 but for the examples instead of the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the tests ran out of stack space due to the many variable-length arrays on the stack (as found out in #162). So allocating on the heap with
mallocinstead. Fixes #156To still be able to do all the matrix indexing, we use variably-modified types (also described in #162). That requires dereferencing to be added in many places and makes the syntax a bit unfamiliar, but it does avoid having to do the indexing manually. So to me this solution would be preferrable.
If the solution using manual indexing is preferred (mjacobse@b61dc5a), let me know and I can create a pull request with that instead.