Pull Request - CI/CD Part 2 Pipeline to Sandbox- Digital Dreamers #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hash2004 Kindly review this and share any further feedback you may have! |
hash2004
requested changes
Sep 2, 2024
Dockerfile
Outdated
| @@ -16,4 +16,4 @@ COPY ./app /code/app | |||
|
|
|||
| ENV PYTHONPATH=/code/app | |||
|
|
|||
| CMD ["fastapi", "dev", "app/main.py", "--host=0.0.0.0", "--port=8000"] | |||
There was a problem hiding this comment.
We are currently using port 8000 for our backend. Could you clarify why we are using port 8080 here? Other than that, good job! Super clean :)
There was a problem hiding this comment.
Thank you for pointing out the mistake. I initially thought that google cloud port 8000 was a default variable that could not be modified. Following the Google Cloud Run documentation, I set the port parameter by --port 8000 in gcloud run deploy and reverted the Dockerfile to its previous state. The changes have passed the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Th CI/CD pipeline created using a YAML configuration automates the process of building, testing, and deploying your application to Google Cloud Run, ensuring a streamlined and secure deployment process.
Changes
ci-cd.yml(Location: .github/workflows/ci-cd.yml)requirements.txt. ‘Fastapi’ changed to ‘fastapi[standard]'Testing
Setting Up GitHub Actions and Configuring GCP Cloud Run: GitHub Actions was activated for the code repository for the first time. As part of the setup, the Google Cloud Run API was enabled to allow deployment of the application. Additionally, a Google Cloud service account was created, and its JSON key was securely stored as a GitHub Secret (
GOOGLE_CREDENTIAL) to authenticate the deployment process.Triggering the YAML file through GitHub Actions: The ‘ci-cd.yml’ file triggers the workflow for the pipeline with continuous integration and deployment. Each time a new pull request is made and closed on
stagingbranch, continuous integration/deployment is triggered using GitHub actions.Results
The pipeline passes all the tests, and the repo can complete CI/CD process.
Notes
Screenshots