Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Container::UploadObject() not returning Etag and ContentType #684

Open
wants to merge 1 commit into
base: working
Choose a base branch
from

Conversation

evach-vf
Copy link
Contributor

Container::setContent() is resetting both Etag and ContentType so I moved this call before the Container::populateFromResponse() call in order to get those values from the headers.

Fix issue #683

Container::setContent() is resetting both Etag and ContentType so I moved this call before the Container::populateFromResponse() call in order to get those values from the headers.
@coveralls
Copy link

coveralls commented Jul 22, 2016

Coverage Status

Coverage remained the same at 88.818% when pulling bb8a0e8 on vanilla:hotfix/pr-uploadObject-etag into 3ffee7b on rackspace:working.

@benms
Copy link

benms commented Jan 5, 2017

For normal build in TravisCI you can modify composer.json, change version of satooshi/php-coveralls to 1.0 (see commit 1bcb1d1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants