Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle path_repsonse and ack_mp #239

Closed
wants to merge 5 commits into from
Closed

bundle path_repsonse and ack_mp #239

wants to merge 5 commits into from

Conversation

mirjak
Copy link
Collaborator

@mirjak mirjak commented Jun 30, 2023

fixes #226

draft-ietf-quic-multipath.md Outdated Show resolved Hide resolved
non-probing frames on a path in "Validating" state, as it has no
guarantee that packets will actually reach the peer.
guarantee that packets will actually reach the peer, with an exception
of the ACK_MP frame. An endhost MAY bundle the ACK_MP frame with the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, this text builds on the fact that ACK_MP is a non-probing frame (because ACK is a non-probing frame), and states that even though ACK_MP is a non-probing frame it can be sent in a probe packet.

I wonder if it would be less confusing to simply state that ACK_MP is a probing frame?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what to do here but let's further discuss this in issue #226 (and #50)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazuho I agree with you. I think making ACK_MP a probing frame is the easiest fix.

draft-ietf-quic-multipath.md Outdated Show resolved Hide resolved
draft-ietf-quic-multipath.md Outdated Show resolved Hide resolved
Comment on lines +548 to +550
PATH_RESPONSE frame; in this case it is RECOMMENDED to consider
the acknowledgement information as opportunistic and repeat
the acknowledged packet ranges in the next ACK_MP frame.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this needs to be called out explicitly. ACKs are always opportunistic in QUIC, as ACK frames are not ack-eliciting.

Section 13.2.4 of RFC 9000 defines how to prune old ACK ranges, and I don't think we need to do anything special here.

draft-ietf-quic-multipath.md Outdated Show resolved Hide resolved
@mirjak
Copy link
Collaborator Author

mirjak commented Oct 20, 2023

replace by PR #276

@mirjak mirjak closed this Oct 20, 2023
@mirjak mirjak deleted the mirjak-patch-24 branch March 12, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sending ACK_MP for packets arriving on a path yet to be validated
4 participants