Fixes issues with platforms w/o quarkus-bom and extension catalog metadata map merging #43512
Conversation
quarkus-bot
bot
added
area/devtools
This comment has been minimized.
This comment has been minimized.
|
The failure is related to a path in the test on Windows. I'll fix it, otherwise it's ok to review. |
but is meant to be a layer on top of one that includes a quarkus-bom
passing codestart data under metadata/project/codestarts-data
aloubyansky
force-pushed
the
platform-wo-quarkus-bom
branch
from
5135256
to
decd977
Compare
| @@ -532,6 +532,53 @@ It is going to be merged with the other codestarts config and automatically conv | |||
| * You can start with java and add kotlin later in another PR (create an issue so you don't forget). | |||
| * If you have a question, ping me @ia3andy on https://quarkusio.zulipchat.com/. | |||
|
|
|||
| === Platform codestarts data | |||
There was a problem hiding this comment.
@ia3andy I added a little doc here about metadata/project/codestart-data
|
🙈 The PR is closed and the preview is expired. |
Status for workflow
|
| "metadata" : { | ||
| "project" : { <1> | ||
| "codestart-data" : { <2> | ||
| "quarkus-magic-codestart" : { <3> |
There was a problem hiding this comment.
Just to understand the scope of the data bindings here. This is linked via the code start name - nothing else; no group artifact version etc.
Correct?
that name isnt unique, right ? So if you have two codestarts using same name they both get this or does it get treated as an error ?
There was a problem hiding this comment.
Yes, it's the codestart name. If there are multiple codestarts with the same name and using the same property names that will likely lead to a problem.
Fixes #43236
@ia3andy this should be it. Except I should mention
metadata/project/codestarts-datasomewhere in the docs