Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.15] Adding an attribute for the TLS registry reference guide #43458

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

MichalMaler
Copy link
Contributor

@MichalMaler MichalMaler commented Sep 24, 2024

Adding an attribute for the TLS registry reference guide.
Cherry-pick of c265a8b of #43446

@quarkus-bot quarkus-bot bot changed the title Adding an attribute for the TLS registry reference guide [3.15] Adding an attribute for the TLS registry reference guide Sep 24, 2024
@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Sep 24, 2024
@aloubyansky
Copy link
Member

FYI @gsmet

@MichalMaler
Copy link
Contributor Author

Hello @aloubyansky and @gsmet. I just wanted to have this little thing merged and backported so that I can test it before handing it all over to QE; thus, I opted for the manual cherry-pick backport directly to 3.15 instead of just putting a label on my "main" PR. Hope I didn't created any mess :) In most cases, I will go with the normal flow of just creating PRs against main and adding the label.

Please let me know if this is OK.
I removed the backport label in my original PR: #43446

Copy link

github-actions bot commented Sep 24, 2024

🙈 The PR is closed and the preview is expired.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 24, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 7b841c8.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a vague recollection that we had issues with attributes in titles on the website but apparently it works now: https://quarkus.io/version/main/guides/tls-registry-reference .

@gsmet gsmet merged commit 32b4fe0 into quarkusio:3.15 Sep 24, 2024
5 checks passed
@MichalMaler MichalMaler deleted the Adding-the-TLS-guide-attribute branch September 24, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants